mirror of
https://github.com/mastodon/mastodon.git
synced 2024-12-22 16:25:19 +01:00
Fix web UI crash when a encoutering an orphaned notification group
Fixes #31392
This commit is contained in:
parent
b42661ba95
commit
4c996964c7
1 changed files with 21 additions and 1 deletions
|
@ -20,6 +20,21 @@ import { NotificationSeveredRelationships } from './notification_severed_relatio
|
||||||
import { NotificationStatus } from './notification_status';
|
import { NotificationStatus } from './notification_status';
|
||||||
import { NotificationUpdate } from './notification_update';
|
import { NotificationUpdate } from './notification_update';
|
||||||
|
|
||||||
|
function missingActivity(notificationGroup: NotificationGroupModel) {
|
||||||
|
switch (notificationGroup.type) {
|
||||||
|
case 'reblog':
|
||||||
|
case 'favourite':
|
||||||
|
case 'mention':
|
||||||
|
case 'update':
|
||||||
|
case 'status':
|
||||||
|
case 'poll':
|
||||||
|
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition -- our type is actually not correct as the server can occasionally have orphaned notifications
|
||||||
|
return notificationGroup.statusId === null;
|
||||||
|
default:
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
export const NotificationGroup: React.FC<{
|
export const NotificationGroup: React.FC<{
|
||||||
notificationGroupId: NotificationGroupModel['group_key'];
|
notificationGroupId: NotificationGroupModel['group_key'];
|
||||||
unread: boolean;
|
unread: boolean;
|
||||||
|
@ -60,7 +75,12 @@ export const NotificationGroup: React.FC<{
|
||||||
[dispatch, notificationGroupId, accountId, onMoveUp, onMoveDown],
|
[dispatch, notificationGroupId, accountId, onMoveUp, onMoveDown],
|
||||||
);
|
);
|
||||||
|
|
||||||
if (!notificationGroup || notificationGroup.type === 'gap') return null;
|
if (
|
||||||
|
!notificationGroup ||
|
||||||
|
notificationGroup.type === 'gap' ||
|
||||||
|
missingActivity(notificationGroup)
|
||||||
|
)
|
||||||
|
return null;
|
||||||
|
|
||||||
let content;
|
let content;
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue