From 9067a7f69664caf259a0ceef421a3f1ae111673f Mon Sep 17 00:00:00 2001
From: Matt Jankowski <matt@jankowski.online>
Date: Mon, 16 Dec 2024 11:24:05 -0500
Subject: [PATCH] Convert `settings/preferences/notifications` controller spec
 to system (#33322)

---
 .../notifications_controller_spec.rb          | 43 -------------------
 .../preferences/notifications_spec.rb         | 27 ++++++++++++
 2 files changed, 27 insertions(+), 43 deletions(-)
 delete mode 100644 spec/controllers/settings/preferences/notifications_controller_spec.rb
 create mode 100644 spec/system/settings/preferences/notifications_spec.rb

diff --git a/spec/controllers/settings/preferences/notifications_controller_spec.rb b/spec/controllers/settings/preferences/notifications_controller_spec.rb
deleted file mode 100644
index edfdea50e0..0000000000
--- a/spec/controllers/settings/preferences/notifications_controller_spec.rb
+++ /dev/null
@@ -1,43 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe Settings::Preferences::NotificationsController do
-  render_views
-
-  let(:user) { Fabricate(:user) }
-
-  before do
-    sign_in user, scope: :user
-  end
-
-  describe 'GET #show' do
-    before do
-      get :show
-    end
-
-    it 'returns http success with private cache control headers', :aggregate_failures do
-      expect(response).to have_http_status(200)
-      expect(response.headers['Cache-Control']).to include('private, no-store')
-    end
-  end
-
-  describe 'PUT #update' do
-    it 'updates notifications settings' do
-      user.settings.update('notification_emails.follow': false)
-      user.save
-
-      put :update, params: {
-        user: {
-          settings_attributes: {
-            'notification_emails.follow': '1',
-          },
-        },
-      }
-
-      expect(response).to redirect_to(settings_preferences_notifications_path)
-      user.reload
-      expect(user.settings['notification_emails.follow']).to be true
-    end
-  end
-end
diff --git a/spec/system/settings/preferences/notifications_spec.rb b/spec/system/settings/preferences/notifications_spec.rb
new file mode 100644
index 0000000000..20ff549222
--- /dev/null
+++ b/spec/system/settings/preferences/notifications_spec.rb
@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe 'Settings preferences notifications page' do
+  let(:user) { Fabricate :user }
+
+  before { sign_in user }
+
+  it 'Views and updates user prefs' do
+    visit settings_preferences_notifications_path
+
+    expect(page)
+      .to have_private_cache_control
+
+    uncheck notifications_follow_field
+
+    expect { click_on submit_button }
+      .to change { user.reload.settings['notification_emails.follow'] }.to(false)
+    expect(page)
+      .to have_title(I18n.t('settings.notifications'))
+  end
+
+  def notifications_follow_field
+    I18n.t('simple_form.labels.notification_emails.follow')
+  end
+end