From f721e76d1385fbccdb4504232b8ab02c86d838f7 Mon Sep 17 00:00:00 2001 From: Matt Jankowski Date: Wed, 11 Dec 2024 03:58:59 -0500 Subject: [PATCH] Avoid double request in `admin/export_domain_allows` controller spec (#33255) --- .../export_domain_allows_controller_spec.rb | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/spec/controllers/admin/export_domain_allows_controller_spec.rb b/spec/controllers/admin/export_domain_allows_controller_spec.rb index 0a2e342620..0a56394193 100644 --- a/spec/controllers/admin/export_domain_allows_controller_spec.rb +++ b/spec/controllers/admin/export_domain_allows_controller_spec.rb @@ -32,15 +32,16 @@ RSpec.describe Admin::ExportDomainAllowsController do it 'allows imported domains' do post :import, params: { admin_import: { data: fixture_file_upload('domain_allows.csv') } } - expect(response).to redirect_to(admin_instances_path) + expect(response) + .to redirect_to(admin_instances_path) - # Header should not be imported - expect(DomainAllow.where(domain: '#domain').present?).to be(false) - - # Domains should now be added - get :export, params: { format: :csv } - expect(response).to have_http_status(200) - expect(response.body).to eq(domain_allows_csv_file) + # Header row should not be imported, but domains should + expect(DomainAllow) + .to_not exist(domain: '#domain') + expect(DomainAllow) + .to exist(domain: 'good.domain') + expect(DomainAllow) + .to exist(domain: 'better.domain') end it 'displays error on no file selected' do