OpenSource/misskey
OpenSource/misskey
1
0
Fork 0
mirror of https://github.com/misskey-dev/misskey.git synced 2024-12-29 07:49:53 +01:00
Code Issues Projects Releases Packages Wiki Activity

refactor: remove unnecessary max/min function

Browse source
This commit is contained in:
anatawa12 2024-06-14 17:48:05 +09:00
parent 4af9c90d12
commit 0ef7f14fa9
No known key found for this signature in database
GPG key ID: 9CA909848B8E4EA6
1 changed files with 28 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
packages/backend/src/server/api/RateLimiterService.ts
View file

@ -49,7 +49,6 @@ export class RateLimiterService {
} }
// Short-term limit // Short-term limit
const min = async () => {
if (limitation.minInterval != null) { if (limitation.minInterval != null) {
const info = await this.checkLimiter({ const info = await this.checkLimiter({
id: `${actor}:${limitation.key}:min`, id: `${actor}:${limitation.key}:min`,
@ -57,16 +56,16 @@ export class RateLimiterService {
max: 1, max: 1,
db: this.redisClient, db: this.redisClient,
}); });
this.logger.debug(`${actor} ${limitation.key} min remaining: ${info.remaining}`); this.logger.debug(`${actor} ${limitation.key} min remaining: ${info.remaining}`);
if (info.remaining === 0) { if (info.remaining === 0) {
// eslint-disable-next-line no-throw-literal // eslint-disable-next-line no-throw-literal
throw { code: 'BRIEF_REQUEST_INTERVAL', info }; throw { code: 'BRIEF_REQUEST_INTERVAL', info };
} }
} }
};
// Long term limit // Long term limit
const max = async () => {
if (limitation.duration != null && limitation.max != null) { if (limitation.duration != null && limitation.max != null) {
const info = await this.checkLimiter({ const info = await this.checkLimiter({
id: `${actor}:${limitation.key}`, id: `${actor}:${limitation.key}`,
@ -74,15 +73,13 @@ export class RateLimiterService {
max: limitation.max / factor, max: limitation.max / factor,
db: this.redisClient, db: this.redisClient,
}); });
this.logger.debug(`${actor} ${limitation.key} max remaining: ${info.remaining}`); this.logger.debug(`${actor} ${limitation.key} max remaining: ${info.remaining}`);
if (info.remaining === 0) { if (info.remaining === 0) {
// eslint-disable-next-line no-throw-literal // eslint-disable-next-line no-throw-literal
throw { code: 'RATE_LIMIT_EXCEEDED', info }; throw { code: 'RATE_LIMIT_EXCEEDED', info };
} }
} }
};
await min();
await max();
} }
} }