From 95939e499134b59cd840cb1a0d4cc87bdfb63f43 Mon Sep 17 00:00:00 2001 From: MeiMei <30769358+mei23@users.noreply.github.com> Date: Sat, 27 Feb 2021 17:37:12 +0900 Subject: [PATCH 1/2] Update y18n in yarn.lock (#7246) --- yarn.lock | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/yarn.lock b/yarn.lock index a2e691da4a..b8edcb8501 100644 --- a/yarn.lock +++ b/yarn.lock @@ -11351,14 +11351,14 @@ xtend@^4.0.0, xtend@~4.0.0, xtend@~4.0.1: integrity sha512-LKYU1iAXJXUgAXn9URjiu+MWhyUXHsvfp7mcuYm9dSUKK0/CjtrUwFAxD82/mCWbtLsGjFIad0wIsod4zrTAEQ== y18n@^3.2.1: - version "3.2.1" - resolved "https://registry.yarnpkg.com/y18n/-/y18n-3.2.1.tgz#6d15fba884c08679c0d77e88e7759e811e07fa41" - integrity sha1-bRX7qITAhnnA136I53WegR4H+kE= + version "3.2.2" + resolved "https://registry.yarnpkg.com/y18n/-/y18n-3.2.2.tgz#85c901bd6470ce71fc4bb723ad209b70f7f28696" + integrity sha512-uGZHXkHnhF0XeeAPgnKfPv1bgKAYyVvmNL1xlKsPYZPaIHxGti2hHqvOCQv71XMsLxu1QjergkqogUnms5D3YQ== y18n@^4.0.0: - version "4.0.0" - resolved "https://registry.yarnpkg.com/y18n/-/y18n-4.0.0.tgz#95ef94f85ecc81d007c264e190a120f0a3c8566b" - integrity sha512-r9S/ZyXu/Xu9q1tYlpsLIsa3EeLXXk0VwlxqTcFRfg9EhMW+17kbt9G0NrgCmhGb5vT2hyhJZLfDGx+7+5Uj/w== + version "4.0.1" + resolved "https://registry.yarnpkg.com/y18n/-/y18n-4.0.1.tgz#8db2b83c31c5d75099bb890b23f3094891e247d4" + integrity sha512-wNcy4NvjMYL8gogWWYAO7ZFWFfHcbdbE57tZO8e4cbpj8tfUcwrwqSl3ad8HxpYWCdXcJUCeKKZS62Av1affwQ== y18n@^5.0.5: version "5.0.5" From 4c01dcd8eb2bb9bed889c76cf4e192ea11914d61 Mon Sep 17 00:00:00 2001 From: MeiMei <30769358+mei23@users.noreply.github.com> Date: Sat, 27 Feb 2021 17:39:55 +0900 Subject: [PATCH 2/2] Fix #7248 (#7250) * Fix #7248 * fix * fix * fix * avoid infinite loop --- src/boot/index.ts | 4 +++- src/services/logger.ts | 8 +++++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/boot/index.ts b/src/boot/index.ts index 7380c4484d..602f6b0e48 100644 --- a/src/boot/index.ts +++ b/src/boot/index.ts @@ -66,7 +66,9 @@ if (!program.quiet) { // Display detail of uncaught exception process.on('uncaughtException', err => { - logger.error(err); + try { + logger.error(err); + } catch { } }); // Dying away... diff --git a/src/services/logger.ts b/src/services/logger.ts index eb2b257dde..c7483d3faa 100644 --- a/src/services/logger.ts +++ b/src/services/logger.ts @@ -94,7 +94,7 @@ export default class Logger { level === 'info' ? this.syslogClient.info : null as never; - send.bind(this.syslogClient)(message); + send.bind(this.syslogClient)(message).catch(() => {}); } else { const Logs = getRepository(Log); Logs.insert({ @@ -106,7 +106,7 @@ export default class Logger { level: level, message: message.substr(0, 1000), // 1024を超えるとログが挿入できずエラーになり無限ループする data: data, - } as Log); + } as Log).catch(() => {}); } } } @@ -116,8 +116,10 @@ export default class Logger { data = data || {}; data.e = x; this.log('error', x.toString(), data, important); + } else if (typeof x === 'object') { + this.log('error', `${(x as any).message || (x as any).name || x}`, data, important); } else { - this.log('error', x, data, important); + this.log('error', `${x}`, data, important); } }