OpenSource/python-telegram-bot
OpenSource/python-telegram-bot
1
0
Fork 0
mirror of https://github.com/python-telegram-bot/python-telegram-bot.git synced 2025-03-13 11:18:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix ConversationHandler.check_update not respecting per_user (#3128)

Browse source
This commit is contained in:
Bibo-Joshi 2022-07-03 15:21:04 +02:00 • committed by GitHub
parent f1d03393de
commit 2ecb8d5413
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
telegram/ext/_conversationhandler.py
View file

@ -693,6 +693,8 @@ class ConversationHandler(BaseHandler[Update, CCT]):
return None
if self.per_chat and not update.effective_chat:
return None
if self.per_user and not update.effective_user:
return None
if self.per_message and not update.callback_query:
return None
if update.callback_query and self.per_chat and not update.callback_query.message:

6
tests/test_conversationhandler.py
View file

@ -740,6 +740,12 @@ class TestConversationHandler:
],
bot=bot,
)
# First check that updates without user won't be handled
message.from_user = None
assert not handler.check_update(Update(update_id=0, message=message))
message.from_user = user1
async with app:
await app.process_update(Update(update_id=0, message=message))