OpenSource/python-telegram-bot
OpenSource/python-telegram-bot
1
0
Fork 0
mirror of https://github.com/python-telegram-bot/python-telegram-bot.git synced 2025-03-29 09:40:31 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix Filters.regex failing on non-text message (#1158)

Browse source 
* Fix #1115

* Improve regex filter test
This commit is contained in:
Dmitry Grigoryev 2018-08-26 21:39:01 +03:00 • committed by Jasmin Bom
parent d4b5bd40a5
commit 8acff56145
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
telegram/ext/filters.py
View file

@ -198,7 +198,9 @@ class Filters(object):
# the matched groups and groupdict to the context object. # the matched groups and groupdict to the context object.
def filter(self, message): def filter(self, message):
return bool(self.pattern.search(message.text)) if message.text:
return bool(self.pattern.search(message.text))
return False
class _Reply(BaseFilter): class _Reply(BaseFilter):
name = 'Filters.reply' name = 'Filters.reply'

3
tests/test_filters.py
View file

@ -68,6 +68,9 @@ class TestFilters(object):
message.text = 'i love python' message.text = 'i love python'
assert Filters.regex(r'.\b[lo]{2}ve python')(message) assert Filters.regex(r'.\b[lo]{2}ve python')(message)
message.text = None
assert not Filters.regex(r'fail')(message)
def test_filters_reply(self, message): def test_filters_reply(self, message):
another_message = Message(1, User(1, 'TestOther', False), datetime.datetime.now(), another_message = Message(1, User(1, 'TestOther', False), datetime.datetime.now(),
Chat(0, 'private')) Chat(0, 'private'))