OpenSource/python-telegram-bot
OpenSource/python-telegram-bot
1
0
Fork 0
mirror of https://github.com/python-telegram-bot/python-telegram-bot.git synced 2025-03-26 16:38:53 +01:00
Code Issues Projects Releases Packages Wiki Activity

Improve Error Messages in CommandHandler.__init__ (#2837)

Browse source
This commit is contained in:
Bibo-Joshi 2021-12-31 16:04:21 +01:00 • committed by Hinrich Mahler
parent ced58b790e
commit 9a8c76fc2b
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
telegram/ext/_commandhandler.py
View file

@ -97,7 +97,7 @@ class CommandHandler(Handler[Update, CCT]):
self.command = [x.lower() for x in command] self.command = [x.lower() for x in command]
for comm in self.command: for comm in self.command:
if not re.match(r'^[\da-z_]{1,32}$', comm): if not re.match(r'^[\da-z_]{1,32}$', comm):
raise ValueError('Command is not a valid bot command') raise ValueError(f'Command `{comm}` is not a valid bot command')
self.filters = filters if filters is not None else filters_module.UpdateType.MESSAGES self.filters = filters if filters is not None else filters_module.UpdateType.MESSAGES

4
tests/test_commandhandler.py
View file

@ -173,7 +173,9 @@ class TestCommandHandler(BaseTest):
ids=['too long', 'invalid letter', 'invalid characters'], ids=['too long', 'invalid letter', 'invalid characters'],
) )
def test_invalid_commands(self, cmd): def test_invalid_commands(self, cmd):
with pytest.raises(ValueError, match='not a valid bot command'): with pytest.raises(
ValueError, match=f'`{re.escape(cmd.lower())}` is not a valid bot command'
):
CommandHandler(cmd, self.callback_basic) CommandHandler(cmd, self.callback_basic)
def test_command_list(self): def test_command_list(self):