Ignore private attributes in TelegramObject.to_dict() (#1989)

telegram/base.py

@@ -57,12 +57,7 @@ class TelegramObject(object):
         data = dict()
 
         for key in iter(self.__dict__):
-            if key in ('bot',
+            if key == 'bot' or key.startswith('_'):
-                       '_id_attrs',
-                       '_credentials',
-                       '_decrypted_credentials',
-                       '_decrypted_data',
-                       '_decrypted_secret'):
                 continue
 
             value = self.__dict__[key]

tests/test_telegramobject.py

@@ -74,3 +74,12 @@ class TestTelegramObject(object):
 
         monkeypatch.setattr('telegram.TelegramObject.to_dict', lambda _: d)
         telegram_object.to_json()
+
+    def test_to_dict_private_attribute(self):
+        class TelegramObjectSubclass(TelegramObject):
+            def __init__(self):
+                self.a = 1
+                self._b = 2
+
+        subclass_instance = TelegramObjectSubclass()
+        assert subclass_instance.to_dict() == {'a': 1}