Make context-based callbacks the default setting (#2050)

telegram/ext/dispatcher.py

@@ -117,10 +117,9 @@ class Dispatcher:
             ``@run_async`` decorator and :meth:`run_async`. Defaults to 4.
         persistence (:class:`telegram.ext.BasePersistence`, optional): The persistence class to
             store data that should be persistent over restarts.
-        use_context (:obj:`bool`, optional): If set to :obj:`True` Use the context based
+        use_context (:obj:`bool`, optional): If set to :obj:`True` uses the context based callback
-            callback API.
+            API (ignored if `dispatcher` argument is used). Defaults to :obj:`True`.
-            During the deprecation period of the old API the default is :obj:`False`.
+            **New users**: set this to :obj:`True`.
-            **New users**: Set this to :obj:`True`.
 
     """
 
@@ -136,7 +135,7 @@ class Dispatcher:
                  exception_event=None,
                  job_queue=None,
                  persistence=None,
-                 use_context=False):
+                 use_context=True):
         self.bot = bot
         self.update_queue = update_queue
         self.job_queue = job_queue

telegram/ext/updater.py

@@ -82,9 +82,9 @@ class Updater:
             `telegram.utils.request.Request` object (ignored if `bot` or `dispatcher` argument is
             used). The request_kwargs are very useful for the advanced users who would like to
             control the default timeouts and/or control the proxy used for http communication.
-        use_context (:obj:`bool`, optional): If set to :obj:`True` Use the context based callback
+        use_context (:obj:`bool`, optional): If set to :obj:`True` uses the context based callback
-            API (ignored if :attr:`dispatcher` argument is used). During the deprecation period of
+            API (ignored if `dispatcher` argument is used). Defaults to :obj:`True`.
-            the old API the default is :obj:`False`. **New users**: set this to :obj:`True`.
+            **New users**: set this to :obj:`True`.
         persistence (:class:`telegram.ext.BasePersistence`, optional): The persistence class to
             store data that should be persistent over restarts (ignored if `dispatcher` argument is
             used).
@@ -114,7 +114,7 @@ class Updater:
                  request_kwargs=None,
                  persistence=None,
                  defaults=None,
-                 use_context=False,
+                 use_context=True,
                  dispatcher=None,
                  base_file_url=None):
 

tests/conftest.py

@@ -143,7 +143,7 @@ def cdp(dp):
 
 @pytest.fixture(scope='function')
 def updater(bot):
-    up = Updater(bot=bot, workers=2)
+    up = Updater(bot=bot, workers=2, use_context=False)
     yield up
     if up.running:
         up.stop()

tests/test_dispatcher.py

@@ -480,7 +480,7 @@ class TestDispatcher:
         assert passed == ['start1', 'error', err, 'start3']
         assert passed[2] is err
 
-    def test_error_while_saving_chat_data(self, dp, bot):
+    def test_error_while_saving_chat_data(self, bot):
         increment = []
 
         class OwnPersistence(BasePersistence):
@@ -530,7 +530,7 @@ class TestDispatcher:
                                                                    length=len('/start'))],
                                            bot=bot))
         my_persistence = OwnPersistence()
-        dp = Dispatcher(bot, None, persistence=my_persistence)
+        dp = Dispatcher(bot, None, persistence=my_persistence, use_context=False)
         dp.add_handler(CommandHandler('start', start1))
         dp.add_error_handler(error)
         dp.process_update(update)

tests/test_jobqueue.py

@@ -217,7 +217,7 @@ class TestJobQueue:
         assert self.result == 1
 
     def test_in_updater(self, bot):
-        u = Updater(bot=bot)
+        u = Updater(bot=bot, use_context=False)
         u.job_queue.start()
         try:
             u.job_queue.run_repeating(self.job_run_once, 0.02)