From b44af136e7603d798a89e86e99eeb1815ff49f9d Mon Sep 17 00:00:00 2001 From: Harshil <37377066+harshil21@users.noreply.github.com> Date: Mon, 14 Nov 2022 02:07:20 +0530 Subject: [PATCH] Update PR Template (#3361) --- .github/pull_request_template.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 7d08a667b..5ec383cf8 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -15,14 +15,14 @@ Hey! You're PRing? Cool! Please have a look at the below checklist. It's here to * New classes: - [ ] Added `self._id_attrs` and corresponding documentation - - [ ] `__init__` accepts `**_kwargs` - + - [ ] `__init__` accepts `api_kwargs` as kw-only + * Added new shortcuts: - [ ] In `Chat` & `User` for all methods that accept `chat/user_id` - [ ] In `Message` for all methods that accept `chat_id` and `message_id` - [ ] For new `Message` shortcuts: Added `quote` argument if methods accepts `reply_to_message_id` - [ ] In `CallbackQuery` for all methods that accept either `chat_id` and `message_id` or `inline_message_id` - + * If relevant: - [ ] Added new constants at `telegram.constants` and shortcuts to them as class variables @@ -32,6 +32,7 @@ Hey! You're PRing? Cool! Please have a look at the below checklist. It's here to - [ ] Add the handlers to the warning loop in the `ConversationHandler` - [ ] Added new filters for new message (sub)types - [ ] Added or updated documentation for the changed class(es) and/or method(s) + - [ ] Added the new method(s) to `_extbot.py` - [ ] Added or updated `bot_methods.rst` - - [ ] Updated the Bot API version number in all places: `README.rst` and `README_RAW.rst` (including the badge), as well as `telegram.constants.BOT_API_VERSION` + - [ ] Updated the Bot API version number in all places: `README.rst` and `README_RAW.rst` (including the badge), as well as `telegram.constants.BOT_API_VERSION_INFO` - [ ] Added logic for arbitrary callback data in `tg.ext.Bot` for new methods that either accept a `reply_markup` in some form or have a return type that is/contains `telegram.Message`