mirror of
https://github.com/python-telegram-bot/python-telegram-bot.git
synced 2024-12-29 15:49:02 +01:00
8bf88c3231
* Add deepsource config
* Update Badges
* Update Badges some more
* Stupid change to trigger analysis of all files
* Try to get ignore right
* Update badges again
* Get started on fixing issues
* Fix some more issues
* Remove more plank lines
* Docs for de_json/list & to_dict/json
* Some improvements from deepcode.ai
* Some more improvements
* Some more improvements
* More docstrnigs & let's run DS on the tests just for fun
* Autofix issues in 10 files
Resolved issues in the following files via DeepSource Autofix:
1. tests/conftest.py
2. tests/test_bot.py
3. tests/test_commandhandler.py
4. tests/test_conversationhandler.py
5. tests/test_dispatcher.py
6. tests/test_filters.py
7. tests/test_inputmedia.py
8. tests/test_messagehandler.py
9. tests/test_official.py
10. tests/test_persistence.py
* Some more improvements for tests, but that shall be enough
* Some more docstrings for functions
* Some minor stuff, try to fix tests
* Update DS config
* Still more docs
* Doc fixes
* More fixes
* Fix: indent docstring
* Some fixes
* Revert "Stupid change to trigger analysis of all files"
This reverts commit dd46c260
* Review
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: Poolitzer <25934244+Poolitzer@users.noreply.github.com>
178 lines
5.6 KiB
Python
178 lines
5.6 KiB
Python
#!/usr/bin/env python
|
|
#
|
|
# A library that provides a Python interface to the Telegram Bot API
|
|
# Copyright (C) 2015-2021
|
|
# Leandro Toledo de Souza <devs@python-telegram-bot.org>
|
|
#
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU Lesser Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU Lesser Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU Lesser Public License
|
|
# along with this program. If not, see [http://www.gnu.org/licenses/].
|
|
import os
|
|
import inspect
|
|
|
|
import certifi
|
|
import pytest
|
|
from bs4 import BeautifulSoup
|
|
from telegram.vendor.ptb_urllib3 import urllib3
|
|
|
|
import telegram
|
|
from tests.conftest import env_var_2_bool
|
|
|
|
IGNORED_OBJECTS = ('ResponseParameters', 'CallbackGame')
|
|
IGNORED_PARAMETERS = {
|
|
'self',
|
|
'args',
|
|
'_kwargs',
|
|
'read_latency',
|
|
'network_delay',
|
|
'timeout',
|
|
'bot',
|
|
'api_kwargs',
|
|
}
|
|
|
|
|
|
def find_next_sibling_until(tag, name, until):
|
|
for sibling in tag.next_siblings:
|
|
if sibling is until:
|
|
return
|
|
if sibling.name == name:
|
|
return sibling
|
|
|
|
|
|
def parse_table(h4):
|
|
table = find_next_sibling_until(h4, 'table', h4.find_next_sibling('h4'))
|
|
if not table:
|
|
return []
|
|
t = []
|
|
for tr in table.find_all('tr')[1:]:
|
|
t.append([td.text for td in tr.find_all('td')])
|
|
return t
|
|
|
|
|
|
def check_method(h4):
|
|
name = h4.text
|
|
method = getattr(telegram.Bot, name)
|
|
table = parse_table(h4)
|
|
|
|
# Check arguments based on source
|
|
sig = inspect.signature(method, follow_wrapped=True)
|
|
|
|
checked = []
|
|
for parameter in table:
|
|
param = sig.parameters.get(parameter[0])
|
|
assert param is not None, f"Parameter {parameter[0]} not found in {method.__name__}"
|
|
# TODO: Check type via docstring
|
|
# TODO: Check if optional or required
|
|
checked.append(parameter[0])
|
|
|
|
ignored = IGNORED_PARAMETERS.copy()
|
|
if name == 'getUpdates':
|
|
ignored -= {'timeout'} # Has it's own timeout parameter that we do wanna check for
|
|
elif name in (
|
|
f'send{media_type}'
|
|
for media_type in [
|
|
'Animation',
|
|
'Audio',
|
|
'Document',
|
|
'Photo',
|
|
'Video',
|
|
'VideoNote',
|
|
'Voice',
|
|
]
|
|
):
|
|
ignored |= {'filename'} # Convenience parameter
|
|
elif name == 'setGameScore':
|
|
ignored |= {'edit_message'} # TODO: Now deprecated, so no longer in telegrams docs
|
|
elif name == 'sendContact':
|
|
ignored |= {'contact'} # Added for ease of use
|
|
elif name in ['sendLocation', 'editMessageLiveLocation']:
|
|
ignored |= {'location'} # Added for ease of use
|
|
elif name == 'sendVenue':
|
|
ignored |= {'venue'} # Added for ease of use
|
|
elif name == 'answerInlineQuery':
|
|
ignored |= {'current_offset'} # Added for ease of use
|
|
|
|
assert (sig.parameters.keys() ^ checked) - ignored == set()
|
|
|
|
|
|
def check_object(h4):
|
|
name = h4.text
|
|
obj = getattr(telegram, name)
|
|
table = parse_table(h4)
|
|
|
|
# Check arguments based on source
|
|
sig = inspect.signature(obj, follow_wrapped=True)
|
|
|
|
checked = []
|
|
for parameter in table:
|
|
field = parameter[0]
|
|
if field == 'from':
|
|
field = 'from_user'
|
|
elif (
|
|
name.startswith('InlineQueryResult') or name.startswith('InputMedia')
|
|
) and field == 'type':
|
|
continue
|
|
elif (
|
|
name.startswith('PassportElementError') and field == 'source'
|
|
) or field == 'remove_keyboard':
|
|
continue
|
|
|
|
param = sig.parameters.get(field)
|
|
assert param is not None, f"Attribute {field} not found in {obj.__name__}"
|
|
# TODO: Check type via docstring
|
|
# TODO: Check if optional or required
|
|
checked.append(field)
|
|
|
|
ignored = IGNORED_PARAMETERS.copy()
|
|
if name == 'InputFile':
|
|
return
|
|
if name == 'InlineQueryResult':
|
|
ignored |= {'id', 'type'}
|
|
elif name == 'User':
|
|
ignored |= {'type'} # TODO: Deprecation
|
|
elif name in ('PassportFile', 'EncryptedPassportElement'):
|
|
ignored |= {'credentials'}
|
|
elif name == 'PassportElementError':
|
|
ignored |= {'message', 'type', 'source'}
|
|
elif name.startswith('InputMedia'):
|
|
ignored |= {'filename'} # Convenience parameter
|
|
|
|
assert (sig.parameters.keys() ^ checked) - ignored == set()
|
|
|
|
|
|
argvalues = []
|
|
names = []
|
|
http = urllib3.PoolManager(cert_reqs='CERT_REQUIRED', ca_certs=certifi.where())
|
|
request = http.request('GET', 'https://core.telegram.org/bots/api')
|
|
soup = BeautifulSoup(request.data.decode('utf-8'), 'html.parser')
|
|
|
|
for thing in soup.select('h4 > a.anchor'):
|
|
# Methods and types don't have spaces in them, luckily all other sections of the docs do
|
|
# TODO: don't depend on that
|
|
if '-' not in thing['name']:
|
|
h4 = thing.parent
|
|
|
|
# Is it a method
|
|
if h4.text[0].lower() == h4.text[0]:
|
|
argvalues.append((check_method, h4))
|
|
names.append(h4.text)
|
|
elif h4.text not in IGNORED_OBJECTS: # Or a type/object
|
|
argvalues.append((check_object, h4))
|
|
names.append(h4.text)
|
|
|
|
|
|
@pytest.mark.parametrize(('method', 'data'), argvalues=argvalues, ids=names)
|
|
@pytest.mark.skipif(
|
|
not env_var_2_bool(os.getenv('TEST_OFFICIAL')), reason='test_official is not enabled'
|
|
)
|
|
def test_official(method, data):
|
|
method(data)
|