OpenSource/vaultwarden
OpenSource/vaultwarden
1
0
Fork 0
mirror of https://github.com/dani-garcia/vaultwarden.git synced 2024-12-22 22:45:12 +01:00
Code Issues Projects Releases Packages Wiki Activity

Prevent generating an error during ws close (#4127)

Browse source 
When a WebSocket connection was closing it was sending a message after
it was closed already. This generated an error in the logs.
While this error didn't harm any of the functionallity of Vaultwarden it
isn't nice to see them of course.

This PR Fixes this by catching the close message and breaks the loop at
that point. This prevents the `_` catch-all from replying the close
message back to the client, which was causing the error message.

Fixes #4090
This commit is contained in:
Mathijs van Veluw 2023-12-04 20:20:13 +01:00 committed by GitHub
parent 48836501bf
commit 0fdda3bc2f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/api/notifications.rs
View file

@ -164,6 +164,11 @@ fn websockets_hub<'r>(
continue; continue;
} }
} }
// Prevent sending anything back when a `Close` Message is received.
// Just break the loop
Message::Close(_) => break,
// Just echo anything else the client sends // Just echo anything else the client sends
_ => yield message, _ => yield message,
} }
@ -230,6 +235,11 @@ fn anonymous_websockets_hub<'r>(
continue; continue;
} }
} }
// Prevent sending anything back when a `Close` Message is received.
// Just break the loop
Message::Close(_) => break,
// Just echo anything else the client sends // Just echo anything else the client sends
_ => yield message, _ => yield message,
} }