PaperMC/Spigot-Server-Patches/Change-implementation-of-tile-entity-removal-list.patch

From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Joseph Hirschfeld <joe@ibj.io>
Date: Thu, 3 Mar 2016 02:39:54 -0600
Subject: [PATCH] Change implementation of (tile)entity removal list

use sets for faster removal

diff --git a/src/main/java/net/minecraft/server/World.java b/src/main/java/net/minecraft/server/World.java
index ef00928466..caead09a64 100644
--- a/src/main/java/net/minecraft/server/World.java
+++ b/src/main/java/net/minecraft/server/World.java
@@ -0,0 +0,0 @@ public abstract class World implements GeneratorAccess, AutoCloseable {
     public final List<TileEntity> tileEntityList = Lists.newArrayList();
     public final List<TileEntity> tileEntityListTick = Lists.newArrayList();
     protected final List<TileEntity> tileEntityListPending = Lists.newArrayList();
-    protected final List<TileEntity> tileEntityListUnload = Lists.newArrayList();
+    protected final java.util.Set<TileEntity> tileEntityListUnload = com.google.common.collect.Sets.newHashSet();
     public final Thread serverThread;
     private int c;
     protected int i = (new Random()).nextInt();
--
Change implementation of tile entity removal list 2016-02-20 21:34:29 -06:00			`From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001`
			`From: Joseph Hirschfeld <joe@ibj.io>`
Paper 1.9 2016-02-29 17:09:49 -06:00			`Date: Thu, 3 Mar 2016 02:39:54 -0600`
Change implementation of tile entity removal list 2016-02-20 21:34:29 -06:00			`Subject: [PATCH] Change implementation of (tile)entity removal list`

Numerous fixes to entity related changes While it wasn't really "broken" before, if plugins use NMS (which they really should't be) and mess with entity management themselves, and get it wrong, they could ultimately corrupt our state expectations. I've been unable to reproduce any issues locally, but these changes are the result of me analyzing the code pretty deeply and seeing about how to make it more durable to abnormal usage. Any servers seeing oddities, please run with -Ddebug.entities=true and send me any logs triggered. 2019-04-05 23:08:45 -04:00			`use sets for faster removal`
Change implementation of tile entity removal list 2016-02-20 21:34:29 -06:00
			`diff --git a/src/main/java/net/minecraft/server/World.java b/src/main/java/net/minecraft/server/World.java`
Updated Upstream (Bukkit/CraftBukkit/Spigot) Upstream has released updates that appears to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing Bukkit Changes: 93e39ce1 Clarify documentation regarding getMaterial with legacyName = true c3aeaea0 Improve dependency tracker 14c9d275 Add support for transitive depends in load access warning c8afe560 SPIGOT-5526: Add EntityEnterBlockEvent 6bb6f07d SPIGOT-5548: Show error that hints towards plugins misusing reflection ed75537d SPIGOT-5546: Fix bad depend access using wrong provider in message 4e4c0ee9 Fix buggy classloader warning triggering for all classes 89586a4c Print warning when loading classes from depends that have not been specified d4fe9680 Fix bug where disablePlugin could remove ConfigurationSerializable classes from other plugins 85e683b7 Add additional checkstyle checks 612fd8e1 Correct max page count in BookMeta docs fa8a9781 Correct max title length in BookMeta docs CraftBukkit Changes: ab13a117 SPIGOT-5550: Cancelled ProjectileLaunchEvent still plays sound for eggs 44016b1d SPIGOT-5538: Using javaw to run GUI prints input error e653ae76 SPIGOT-5526: Call EntityEnterBlockEvent for bees trying to enter hives 6515ea49 SPIGOT-5537: Bee nests generated by growing trees near flower have no bees d82b3149 Remove unused CraftWorld.getId method 10763a88 Change some block == AIR checks to isAir to catch CAVE_AIR Spigot Changes: f2c1cd15 Rebuild patches bcd458ad Reformat patches 2020-01-28 19:43:57 +00:00			`index ef00928466..caead09a64 100644`
Change implementation of tile entity removal list 2016-02-20 21:34:29 -06:00			`--- a/src/main/java/net/minecraft/server/World.java`
			`+++ b/src/main/java/net/minecraft/server/World.java`
Work on server patches 2019-12-11 00:56:03 +00:00			`@@ -0,0 +0,0 @@ public abstract class World implements GeneratorAccess, AutoCloseable {`
Re-add TileEntity removal list, fix build 2016-03-25 02:50:56 -05:00			`public final List<TileEntity> tileEntityList = Lists.newArrayList();`
Paper 1.9 2016-02-29 17:09:49 -06:00			`public final List<TileEntity> tileEntityListTick = Lists.newArrayList();`
More work for 1.14 2019-04-26 02:24:00 +01:00			`protected final List<TileEntity> tileEntityListPending = Lists.newArrayList();`
			`- protected final List<TileEntity> tileEntityListUnload = Lists.newArrayList();`
Work on server patches 2019-12-11 00:56:03 +00:00			`+ protected final java.util.Set<TileEntity> tileEntityListUnload = com.google.common.collect.Sets.newHashSet();`
1.15.2 update (#2887) Functional GUI fix added by billygalbreath 2020-01-21 18:02:07 -08:00			`public final Thread serverThread;`
Work on server patches 2019-12-11 00:56:03 +00:00			`private int c;`
			`protected int i = (new Random()).nextInt();`
Change implementation of tile entity removal list 2016-02-20 21:34:29 -06:00			`--`