Commit graph

1521 commits

Author SHA1 Message Date
CraftBukkit/Spigot
475d10469d SPIGOT-6980: Since 1.18.2, World#isChunkLoaded returned false for chunks that have just been loaded (e.g. inside ChunkLoadEvent).
Some changes of the 1.18.2 update have been reverted to resolve this regression.

By: blablubbabc <lukas@wirsindwir.de>
2022-03-27 16:24:06 +11:00
CraftBukkit/Spigot
f046a30653 SPIGOT-5140: Call EntityChangeBlockEvent when a ChorusFlower is destroyed by a projectile
By: Brokkonaut <hannos17@gmx.de>
2022-03-21 13:17:54 +11:00
CraftBukkit/Spigot
6796896e63 SPIGOT-3034: PlayerKickEvent.setLeaveMessage(String) doesn't actually do anything
By: DerFrZocker <derrieple@gmail.com>
2022-03-16 19:49:07 +11:00
CraftBukkit/Spigot
85cc664060 SPIGOT-6138, SPIGOT-6415: Don't call CreatureSpawnEvent after cross-dimensional travel
By: DerFrZocker <derrieple@gmail.com>
2022-03-13 07:48:22 +11:00
CraftBukkit/Spigot
06bac38719 SPIGOT-2942: give command fires PlayerDropItemEvent, cancelling it causes Item Duplication
By: DerFrZocker <derrieple@gmail.com>
2022-03-11 21:47:13 +01:00
CraftBukkit/Spigot
1a135e792f SPIGOT-6962: Call EntityChangeBlockEvent when when FallingBlockEntity starts to fall
By: BlackHole <black-hole@live.com>
2022-03-11 16:24:02 +11:00
CraftBukkit/Spigot
ad484e5f73 SPIGOT-6959: Make /loot command ignore empty items for spawn
By: Doc <nachito94@msn.com>
2022-03-08 07:25:44 +11:00
CraftBukkit/Spigot
390618e170 SPIGOT-6956: Reduce differences caused by setKeepSpawnInMemory(false)
By: md_5 <git@md-5.net>
2022-03-04 18:53:19 +11:00
CraftBukkit/Spigot
9ee989ea81 Update to Minecraft 1.18.2
By: md_5 <git@md-5.net>
2022-03-01 02:00:00 +11:00
CraftBukkit/Spigot
2271fc314d SPIGOT-6900, SPIGOT-6330: Make /difficulty command per-world
By: Doc <nachito94@msn.com>
2022-02-21 11:59:30 +11:00
CraftBukkit/Spigot
8216743085 SPIGOT-6936: Cancelling EntityAirChangeEvent doesn't stop player's bubbles from decreasing client side
By: md_5 <git@md-5.net>
2022-02-20 09:25:32 +11:00
CraftBukkit/Spigot
8d542f0b21 SPIGOT-6937: Ramming goat does not throw EntityTargetLivingEntityEvent
By: md_5 <git@md-5.net>
2022-02-20 09:07:37 +11:00
CraftBukkit/Spigot
c48241fce5 SPIGOT-6934: Bring plugin chunk tickets back in line with forceload tickets
By: md_5 <git@md-5.net>
2022-02-20 08:55:27 +11:00
CraftBukkit/Spigot
b9534e1c48 #1009: Add Furnace#getRecipesUsed
By: Doc <nachito94@msn.com>
2022-02-15 18:48:54 +11:00
CraftBukkit/Spigot
77b8e4803a #1010: Add PDC to World
By: DerFrZocker <derrieple@gmail.com>
2022-02-15 09:36:00 +11:00
CraftBukkit/Spigot
314b83ffae SPIGOT-6918: Add SpawnCategory API and configurations for Axolotls
By: Doc <nachito94@msn.com>
2022-02-07 18:47:27 +11:00
CraftBukkit/Spigot
f01afaf08f Don't send updates over large distances
By: md_5 <git@md-5.net>
2022-02-07 08:35:20 +11:00
CraftBukkit/Spigot
765eadbac1 SPIGOT-6782: EntityPortalEvent should not destroy entity when setTo() uses same world as getFrom()
By: DerFrZocker <derrieple@gmail.com>
2022-02-05 18:51:46 +01:00
CraftBukkit/Spigot
9523f87f1c SPIGOT-6917: Use main scoreboard for /trigger
Restores pre-1.13 behaviour. See linked ticket for further discussion.

By: md_5 <git@md-5.net>
2022-02-02 08:59:18 +11:00
CraftBukkit/Spigot
d5e124a72d Clean up callBlockDamageEvent
By: md_5 <git@md-5.net>
2022-02-02 08:56:24 +11:00
CraftBukkit/Spigot
e664c2bf5f SPIGOT-6910: Add BlockDamageAbortEvent
By: FreeSoccerHDX <unconfigured@null.spigotmc.org>
2022-02-02 08:56:23 +11:00
CraftBukkit/Spigot
e2b1313f00 #1004: Call WorldInitEvent before any chunks are generated
By: DerFrZocker <derrieple@gmail.com>
2022-02-01 08:13:13 +11:00
CraftBukkit/Spigot
2fb7e5202f #1003: Fix cancellation of TradeSelectEvent
By: pop4959 <pop4959@gmail.com>
2022-01-29 09:27:01 +11:00
CraftBukkit/Spigot
f46c4e64ea SPIGOT-6890: Add repair cost amount in AnvilInventory
By: Doc <nachito94@msn.com>
2022-01-26 09:30:35 +11:00
CraftBukkit/Spigot
b80113b447 SPIGOT-6907: Oxygen does not restore up to value set by LivingEntity#setMaximumAir()
By: DerFrZocker <derrieple@gmail.com>
2022-01-23 09:06:19 +11:00
CraftBukkit/Spigot
a8b86ea421 #994: Fix changing world in portal events not updating used world border
Also clamp the event's target location to the world border

By: Phoenix616 <max@themoep.de>
2022-01-20 18:36:14 +11:00
CraftBukkit/Spigot
ce2ac2868b SPIGOT-6888: Add SpawnReason for Vex spawned by Evokers
By: Doc <nachito94@msn.com>
2022-01-14 10:55:59 +11:00
CraftBukkit/Spigot
602f8cb433 #989: Add PDC to Structures
By: Martoph <sager1018@gmail.com>
2022-01-07 09:43:05 +11:00
CraftBukkit/Spigot
46f0dde817 SPIGOT-5339, SPIGOT-6252, SPIGOT-6777: Only cancel knockback if the damage event was canceled
By: DerFrZocker <derrieple@gmail.com>
2022-01-03 18:07:01 +01:00
CraftBukkit/Spigot
cc34358a3e SPIGOT-6496: /time functions affect entire server, not just the origin world
By: DerFrZocker <derrieple@gmail.com>
2022-01-03 08:29:31 +11:00
CraftBukkit/Spigot
f5b1ea90e2 SPIGOT-6278: Persistent piglins count towards mob cap
By: md_5 <git@md-5.net>
2022-01-02 11:45:52 +11:00
CraftBukkit/Spigot
1fa87773be #374: Add isJohnny / setJohnny for Vindicator
By: Matthew <stteg@hotmail.com>
2022-01-01 09:58:04 +11:00
CraftBukkit/Spigot
179dbe9592 #373: Add trap related methods to SkeletonHorse
By: Matthew <stteg@hotmail.com>
2022-01-01 09:58:04 +11:00
CraftBukkit/Spigot
7a54f9da31 SPIGOT-5766: The VillagerReplenishTradeEvent is now called when a villager restocks its trades.
By: blablubbabc <lukas@wirsindwir.de>
2021-12-25 10:14:17 +11:00
CraftBukkit/Spigot
aa53cef96f SPIGOT-5627: Leads vanish when transporting leashed entities through a Nether portal
By: DerFrZocker <derrieple@gmail.com>
2021-12-25 09:39:27 +11:00
CraftBukkit/Spigot
28ec7a3566 SPIGOT-6859: PlayerInteractEntityEvent#setCancelled desync with Axolotls
By: Doc <nachito94@msn.com>
2021-12-22 08:04:07 +11:00
CraftBukkit/Spigot
3736fd83de SPIGOT-6836: Add more API methods in MerchantRecipe
By: Doc <nachito94@msn.com>
2021-12-18 11:44:34 +11:00
CraftBukkit/Spigot
94c2fa1b14 SPIGOT-6852: BlockReceiveGameEvent#getBlock returning wrong block
By: md_5 <git@md-5.net>
2021-12-14 07:52:43 +11:00
CraftBukkit/Spigot
ef17571a38 SPIGOT-6851: removeRecipe not unregistering recipe ID
By: md_5 <git@md-5.net>
2021-12-13 11:25:22 +11:00
CraftBukkit/Spigot
667cb32115 Update to Minecraft 1.18.1
By: md_5 <git@md-5.net>
2021-12-11 00:11:02 +11:00
CraftBukkit/Spigot
35fdc9103d SPIGOT-6831: Fix llama strength crash
By: md_5 <git@md-5.net>
2021-12-06 15:15:09 +11:00
CraftBukkit/Spigot
24b8f3c641 #971: Remove strong chunk reference in PDC
A previous fix for SPIGOT-6814 implemented a callback function for the
PDC implementation that could be set to actively define a chunk as
unsaved, allowing chunks that have not been mutated through block
changes to still require saving if the chunks pdc was mutated.

This implementation however would pass a callback that references the
chunk access internally, meaning the PDC now actively holds onto a
callback that holds a reference to the entire chunk.

Aditionally, this change also impacted the pdc for item metas and
entities for really no reason whatsoever.

This commit re-implements the fix by introducing a new child of the pdc
implementation that the chunk now uses as its pdc. This specific
implementation maintains a dirty flag that is set to `true` on any form
of mutation and set back to false by the chunk that owns the PDC
whenever the chunk itself is flag as no longer dirty.

By: Bjarne Koll <lynxplay101@gmail.com>
2021-12-05 08:52:51 +11:00
CraftBukkit/Spigot
6646c417c5 Purge hidden entities on unload too
By: md_5 <git@md-5.net>
2021-12-04 08:23:26 +11:00
CraftBukkit/Spigot
4f6a5feac8 #967: Store last lava contact location for events
By: Rafael S. M. Santos <eu@rafaelsms.com>
2021-12-04 08:06:32 +11:00
CraftBukkit/Spigot
77f4cb35ff SPIGOT-6833: Do not drop items into unrestricted world during world generation
By: md_5 <git@md-5.net>
2021-12-04 07:19:56 +11:00
CraftBukkit/Spigot
05d379a339 Release POIs when villagers are removed by plugins
By: md_5 <git@md-5.net>
2021-12-03 15:05:20 +11:00
CraftBukkit/Spigot
ea74321d65 SPIGOT-6823: Fix loading custom world in combination with superflat
By: md_5 <git@md-5.net>
2021-12-03 08:34:38 +11:00
CraftBukkit/Spigot
9f2d553877 Fix per-world worldborder command
By: md_5 <git@md-5.net>
2021-12-03 07:34:39 +11:00
CraftBukkit/Spigot
ee342addea Better preserve broken PlayerMoveEvent behaviour
By: md_5 <git@md-5.net>
2021-12-02 12:45:58 +11:00
CraftBukkit/Spigot
7dd6dfc7a4 SPIGOT-6828: <player> fell off a ladder/vines death message not supported
By: md_5 <git@md-5.net>
2021-12-02 12:29:35 +11:00
CraftBukkit/Spigot
a0201b0f02 SPIGOT-6795: Fix BlockFertilizeEvent not being triggered for Azaleas
By: Rafael S. M. Santos <eu@rafaelsms.com>
2021-12-01 08:27:58 +11:00
CraftBukkit/Spigot
cc70f18bef SPIGOT-6820: VillagerCareerChangeEvent's ChangeReason is sometimes incorrect
By: Doc <nachito94@msn.com>
2021-12-01 08:26:14 +11:00
CraftBukkit/Spigot
4dbb83e45d SPIGOT-6817: Revert back to old block state behaviour again
By: md_5 <git@md-5.net>
2021-11-29 11:03:16 +11:00
CraftBukkit/Spigot
6b0484122e SPIGOT-6814: (Chunk) PersistentData is lost after restart
By: DerFrZocker <derrieple@gmail.com>
2021-11-29 09:28:19 +11:00
CraftBukkit/Spigot
95ab0e27a8 Add hideEntity / showEntity API
By: md_5 <git@md-5.net>
2021-11-29 09:18:52 +11:00
CraftBukkit/Spigot
27643e5df2 Update to Minecraft 1.18-rc3
By: md_5 <git@md-5.net>
2021-11-27 08:00:00 +11:00
CraftBukkit/Spigot
799bfc92e2 Update to Minecraft 1.18-pre8
By: md_5 <git@md-5.net>
2021-11-25 08:00:00 +11:00
CraftBukkit/Spigot
34c3a49371 SPIGOT-6803: Fix ServerPing not using the new logic for show players in 1.18
By: Doc <nachito94@msn.com>
2021-11-24 07:28:22 +11:00
CraftBukkit/Spigot
3e7bd2643c Improve multi-dimension code
By: md_5 <git@md-5.net>
2021-11-23 18:39:43 +11:00
CraftBukkit/Spigot
820ad30036 SPIGOT-6802: Fix major issues with --forceUpgrade
More to come

By: md_5 <git@md-5.net>
2021-11-23 17:13:52 +11:00
CraftBukkit/Spigot
90f6dfa935 Fix loading / creating secondary worlds (nether/end)
By: md_5 <git@md-5.net>
2021-11-23 15:03:34 +11:00
CraftBukkit/Spigot
43702a9e10 Update to Minecraft 1.18-pre5
By: md_5 <git@md-5.net>
2021-11-22 09:00:00 +11:00
CraftBukkit/Spigot
306648dc4c SPIGOT-6797: EntityInteractEvent called with incorrect location
By: md_5 <git@md-5.net>
2021-11-21 11:22:07 +11:00
CraftBukkit/Spigot
99916e6058 SPIGOT-6798: EntityChangeBlockEvent called with incorrect location
By: md_5 <git@md-5.net>
2021-11-21 11:18:06 +11:00
CraftBukkit/Spigot
9e3a0e859f SPIGOT-6772: Use entity mailbox and re-schedule entities if they get unloaded
By: DerFrZocker <derrieple@gmail.com>
2021-11-01 18:54:44 +11:00
CraftBukkit/Spigot
a2a88c50af #945: Allow setting BrewEvent results
By: Doc <nachito94@msn.com>
2021-10-30 18:16:35 +11:00
CraftBukkit/Spigot
ab1a1deb6b SPIGOT-5988: Bedspawn doesn't clear after dying when spawn is blocked
By: DerFrZocker <derrieple@gmail.com>
2021-10-16 19:39:14 +11:00
CraftBukkit/Spigot
ea404e3d82 SPIGOT-6758: Reset ItemSign#openSign when aborting the block placement early
By: blablubbabc <lukas@wirsindwir.de>
2021-10-16 18:48:22 +11:00
CraftBukkit/Spigot
55f4d6c7cb SPIGOT-6760: Chest#getInventory only returns one half of a double chest when one or both halves are blocked
By: md_5 <git@md-5.net>
2021-10-16 18:48:21 +11:00
CraftBukkit/Spigot
82e8261d70 SPIGOT-6754: We ignore any still present TileEntity now when we create a BlockState for a block of type AIR.
During block destruction, the type of the block may already have been set to AIR while the TileEntity has not yet been removed.
Also, TileEntity#getOwner() skips the whole BlockState construction now if the block is of type AIR.

This removes the previous workaround again of returning a dummy CraftBlockEntityState in this case.

By: blablubbabc <lukas@wirsindwir.de>
2021-10-10 07:55:53 +11:00
CraftBukkit/Spigot
188d3b23d0 SPIGOT-2903: Add Structure API
By: Sander Knauff <sanderknauff@hotmail.com>
2021-10-05 11:56:35 +11:00
CraftBukkit/Spigot
2d0a775210 #934: Support for configuring Water Underground Creatures spawn settings
By: Doc <nachito94@msn.com>
2021-10-05 11:29:52 +11:00
CraftBukkit/Spigot
f27c8f74f8 #877: Improve and simplify CraftBlockState
By: blablubbabc <lukas@wirsindwir.de>
2021-09-29 18:56:16 +10:00
CraftBukkit/Spigot
50d4716e9f SPIGOT-6023, SPIGOT-6745: Fix missing BlockDispenseArmorEvents
By: Lars Dormans <lars.dormans@live.nl>
2021-09-26 00:24:33 +02:00
CraftBukkit/Spigot
b4da42047a #929: Call EntityBlockFormEvent for Wither Rose placed by dead entity
By: Doc <nachito94@msn.com>
2021-09-06 18:57:16 +10:00
CraftBukkit/Spigot
77dcaefa51 SPIGOT-6708: Fix Experience Orb value not being updated in mend event
By: Phoenix616 <max@themoep.de>
2021-09-03 18:37:44 +10:00
CraftBukkit/Spigot
9d22657139 Rebuild patch
By: md_5 <git@md-5.net>
2021-09-01 19:02:09 +10:00
CraftBukkit/Spigot
5c075d59dc SPIGOT-6547: Chunk#getEntities() doesn't return all entities immediately after chunk load
By: DerFrZocker <derrieple@gmail.com>
2021-09-01 18:55:18 +10:00
CraftBukkit/Spigot
08e5ad2b2f SPIGOT-6720: Fix bed explosion checks
By: Doc <nachito94@msn.com>
2021-08-27 19:17:43 +10:00
CraftBukkit/Spigot
c8ef43f1b5 SPIGOT-6722: Close entity manager when unloading world
By: DerFrZocker <derrieple@gmail.com>
2021-08-27 19:14:09 +10:00
CraftBukkit/Spigot
dd503b542b SPIGOT-6686: Changes in MaximumRepairCost for Anvil Rename cause inconsistency
By: DerFrZocker <derrieple@gmail.com>
2021-08-27 19:14:09 +10:00
CraftBukkit/Spigot
49c30227d2 Rebuild patch
By: md_5 <git@md-5.net>
2021-08-22 18:07:39 +10:00
CraftBukkit/Spigot
00c0964347 SPIGOT-6713: Cancelling EntityTransformEvent Causes Deceased Slimes To Not Despawn
By: md_5 <git@md-5.net>
2021-08-22 18:07:31 +10:00
CraftBukkit/Spigot
03aecfb428 SPIGOT-6714: Don't fire PlayerBucketEvent when empty
By: Noah van der Aa <ndvdaa@gmail.com>
2021-08-18 17:06:40 +10:00
CraftBukkit/Spigot
c2e4e91b1b SPIGOT-5880, SPIGOT-5567: New ChunkGenerator API
## **Current API**
The current world generation API is very old and limited when you want to make more complex world generation. Resulting in some hard to fix bugs such as that you cannot modify blocks outside the chunk in the BlockPopulator (which should and was per the docs possible), or strange behavior such as SPIGOT-5880.

## **New API**
With the new API, the generation is more separate in multiple methods and is more in line with Vanilla chunk generation. The new API is designed to as future proof as possible. If for example a new generation step is added it can easily also be added as a step in API by simply creating the method for it. On the other side if a generation step gets removed, the method can easily be called after another, which is the case with surface and bedrock. The new API and changes are also fully backwards compatible with old chunk generators.

### **Changes in the new api**
**Extra generation steps:**
Noise, surface, bedrock and caves are added as steps. With those generation steps three extra methods for Vanilla generation are also added. Those new methods provide the ChunkData instead of returning one. The reason for this is, that the ChunkData is now backed by a ChunkAccess. With this, each step has the information of the step before and the Vanilla information (if chosen by setting a 'should' method to true). The old method is deprecated.

**New class BiomeProvider**
The BiomeProvider acts as Biome source and wrapper for the NMS class WorldChunkManager. With this the underlying Vanilla ChunkGeneration knows which Biome to use for the structure and decoration generation. (Fixes: SPIGOT-5880). Although the List of Biomes which is required in BiomeProvider, is currently not much in use in Vanilla, I decided to add it to future proof the API when it may be required in later versions of Minecraft.
The BiomeProvider is also separated from the ChunkGenerator for plugins which only want to change the biome map, such as single Biome worlds or if some biomes should be more present than others.

**Deprecated isParallelCapable**
Mojang has and is pushing to a more multi threaded chunk generation. This should also be the case for custom chunk generators. This is why the new API only supports multi threaded generation. This does not affect the old API, which is still checking this.

**Base height method added**
This method was added to also bring the Minecraft generator and Bukkit generator more in line. With this it is possible to return the max height of a location (before decorations). This is useful to let most structures know were to place them. This fixes SPIGOT-5567. (This fixes not all structures placement, desert pyramids for example are still way up at y-level 64, This however is more a vanilla bug and should be fixed at Mojangs end).

**WorldInfo Class**
The World object was swapped for a WorldInfo object. This is because many methods of the World object won't work during world generation and would mostly likely result in a deadlock. It contains any information a plugin should need to identify the world.

**BlockPopulator Changes**
Instead of directly manipulating a chunk, changes are now made to a new class LimitedRegion, this class provides methods to populated the chunk and its surrounding area. The wrapping is done so that the population can be moved into the place where Minecraft generates decorations. Where there is no chunk to access yet. By moving it into this place the generation is now async and the surrounding area of the chunk can also be used.

For common methods between the World and LimitedRegion a RegionAccessor was added.

By: DerFrZocker <derrieple@gmail.com>
2021-08-15 08:08:16 +10:00
CraftBukkit/Spigot
3483bd08b3 #913: Handle campfire damage with EntityDamageByBlockEvent
By: Doc <nachito94@msn.com>
2021-08-11 19:05:08 +10:00
CraftBukkit/Spigot
72591f6038 SPIGOT-2222, SPIGOT-6687: Pre-set keepLevel and only use it
By: DerFrZocker <derrieple@gmail.com>
2021-08-11 18:49:49 +10:00
CraftBukkit/Spigot
4beaa19a39 SPIGOT-6682: Blocking with shield not reset after die
By: DerFrZocker <derrieple@gmail.com>
2021-08-04 17:09:09 +10:00
CraftBukkit/Spigot
87f8ab3fb3 SPIGOT-6552: Some inventory types reset cursor on switch
By: DerFrZocker <derrieple@gmail.com>
2021-07-30 19:08:43 +10:00
CraftBukkit/Spigot
dcfc8b355a SPIGOT-6669: Shearing a Mooshroom does not fire EntityDropItemEvent
By: md_5 <git@md-5.net>
2021-07-23 16:36:16 +10:00
CraftBukkit/Spigot
999bd6c0ef SPIGOT-6667: /schedule function not working correctly in other dimensions
By: DerFrZocker <derrieple@gmail.com>
2021-07-23 16:29:04 +10:00
CraftBukkit/Spigot
9273a60cdb SPIGOT-6665: Shearing a Snowman does not drop a carved pumpkin
By: md_5 <git@md-5.net>
2021-07-22 17:51:53 +10:00
CraftBukkit/Spigot
93f615157d #893: Add Crafting methods to API
By: James Peters <jameslfc19@gmail.com>
2021-07-22 11:35:48 +10:00
CraftBukkit/Spigot
2ccd460e09 SPIGOT-6663: Chicken Jockeys chickens don't despawn
By: md_5 <git@md-5.net>
2021-07-22 09:53:26 +10:00
CraftBukkit/Spigot
bfc74e8628 SPIGOT-6545: Unable to set Guardian target via API while awareness is disabled
By: DerFrZocker <derrieple@gmail.com>
2021-07-22 09:36:54 +10:00
CraftBukkit/Spigot
0474cc8833 SPIGOT-6369: Add ItemStack to HangingPlaceEvent
By: DerFrZocker <derrieple@gmail.com>
2021-07-21 09:32:54 +10:00
CraftBukkit/Spigot
8650786dad SPIGOT-6645: Call EntityChangeBlockEvent before PlayerHarvestBlockEvent
By: Brokkonaut <hannos17@gmx.de>
2021-07-19 18:54:13 +10:00
CraftBukkit/Spigot
fd8748b4bd SPIGOT-6657: Add getPlayer to SheepDyeWoolEvent
By: md_5 <git@md-5.net>
2021-07-18 11:08:18 +10:00
CraftBukkit/Spigot
5eb7a2ed61 SPIGOT-6656: CauldronLevelChangeEvent is not fired correctly when dripstone fills the cauldron
By: md_5 <git@md-5.net>
2021-07-18 10:14:55 +10:00
CraftBukkit/Spigot
59f5a7ab59 SPIGOT-6653: Canceling snow bucket placement removes snow from bucket
By: md_5 <git@md-5.net>
2021-07-18 10:06:38 +10:00