OpenSource/Sharkey
OpenSource/Sharkey
1
0
Fork 0
mirror of https://activitypub.software/TransFem-org/Sharkey.git synced 2024-12-28 09:00:18 +01:00
Code Issues Projects Releases Packages Wiki Activity

only "publish to followers" when things really change - fixes #733

Browse source
This commit is contained in:
dakkar 2024-11-27 09:57:24 +00:00
parent 1ec5e846c5
commit fc277839b6
2 changed files with 52 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
packages/backend/src/core/activitypub/ApRendererService.ts
View file

@ -469,6 +469,7 @@ export class ApRendererService {
};
}
// if you change this, also change `server/api/endpoints/i/update.ts`
@bindThis
public async renderPerson(user: MiLocalUser) {
const id = this.userEntityService.genLocalUserUri(user.id);

52
packages/backend/src/server/api/endpoints/i/update.ts
View file

@ -539,7 +539,9 @@ export default class extends Endpoint<typeof meta, typeof paramDef> { // eslint-
}
// フォロワーにUpdateを配信
this.accountUpdateService.publishToFollowers(user.id);
if (this.userNeedsPublishing(user, updates) || this.profileNeedsPublishing(profile, updatedProfile)) {
this.accountUpdateService.publishToFollowers(user.id);
}
const urls = updatedProfile.fields.filter(x => x.value.startsWith('https://'));
for (const url of urls) {
@ -581,4 +583,52 @@ export default class extends Endpoint<typeof meta, typeof paramDef> { // eslint-
// なにもしない
}
}
// these two methods need to be kept in sync with
// `ApRendererService.renderPerson`
private userNeedsPublishing(oldUser: MiLocalUser, newUser: Partial<MiUser>): boolean {
for (const field of ['avatarId', 'bannerId', 'backgroundId', 'isBot', 'username', 'name', 'isLocked', 'isExplorable', 'isCat', 'noindex', 'speakAsCat', 'movedToUri', 'alsoKnownAs'] as (keyof MiUser)[]) {
if (newUser.hasOwnProperty(field) && oldUser[field] !== newUser[field]) {
return true;
}
}
for (const arrayField of ['emojis', 'tags'] as (keyof MiUser)[]) {
if (newUser.hasOwnProperty(arrayField) !== oldUser.hasOwnProperty(arrayField)) {
return true;
}
const oldArray = oldUser[arrayField] ?? [];
const newArray = newUser[arrayField] ?? [];
if (!Array.isArray(oldArray) || !Array.isArray(newArray)) {
return true;
}
if (oldArray.join("\0") !== newArray.join("\0")) {
return true;
}
}
return false;
}
private profileNeedsPublishing(oldProfile: MiUserProfile, newProfile: Partial<MiUserProfile>): boolean {
for (const field of ['description', 'followedMessage', 'birthday', 'location', 'listenbrainz'] as (keyof MiUserProfile)[]) {
if (newProfile.hasOwnProperty(field) && oldProfile[field] !== newProfile[field]) {
return true;
}
}
for (const arrayField of ['fields'] as (keyof MiUserProfile)[]) {
if (newProfile.hasOwnProperty(arrayField) !== oldProfile.hasOwnProperty(arrayField)) {
return true;
}
const oldArray = oldProfile[arrayField] ?? [];
const newArray = newProfile[arrayField] ?? [];
if (!Array.isArray(oldArray) || !Array.isArray(newArray)) {
return true;
}
if (oldArray.join("\0") !== newArray.join("\0")) {
return true;
}
}
return false;
}
}