Commit graph

3313 commits

Author SHA1 Message Date
dakkar
096f122024 Merge branch 'stable' into feature/merge-hotfix 2025-01-01 17:31:59 +00:00
dakkar
f4aa986abd fix scheduled replies becoming quote-boosts
thanks to @CenTdemeern1 for triggering this bug!
see https://kitsunes.club/notes/a2h1y2rq9n

also compare with https://s.thenautilus.net/notes/a2h1y2rqx9

my instance errored out with:

> WARN 1	[remote ap]	Failed to resolve quote
> https://mastodon.social/users/DrALJONES/statuses/110586222749407429
>  for note https://kitsunes.club/notes/a2h1y2rq9n: StatusError: 404 Not
> Found

What happened?

* Charlotte scheduled a reply
* the processor called `findOneBy` with an undefined `note.renote`,
  which probably caused a `select` without any `where`
* a random note was attached as a quote
* that note has been deleted on the original instance but not on
kitsuclub's database
* the rest of fedi didn't notice the quote
2025-01-01 17:10:56 +00:00
dakkar
565c987744 merge: Add file extension to locally-stored media (!832)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/832

Approved-by: dakkar <dakkar@thenautilus.net>
Approved-by: Marie <github@yuugi.dev>
2024-12-31 10:44:22 +00:00
dakkar
befc4512d0 merge: rethrow everything but non-retryable HTTP errors (!837)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/837

Approved-by: Marie <github@yuugi.dev>
Approved-by: Charlotte <timo.herngreen@gmail.com>
2024-12-30 08:52:06 +00:00
Hazelnoot
4b6a338e0d merge: fix: Replace RE2 with RegExp for "mute word" regex validation (resolves #850) (!836)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/836

Closes #850

Approved-by: dakkar <dakkar@thenautilus.net>
Approved-by: Hazelnoot <acomputerdog@gmail.com>
2024-12-26 19:09:49 +00:00
Hazelnoot
9fc562be3d avoid use of any in logger.ts 2024-12-26 13:46:15 -05:00
dakkar
45f7743323 fix types
I don't understand the difference between `any` and `unknown`, but the
type signatures before this branch had `Record<string, any> | null`,
and this code passes the typecheck… mah
2024-12-26 09:33:35 +00:00
Hazelnoot
abb2c37591 re-implement "reduce inbox log spam when fetching blocked / unavailable notes" 2024-12-22 15:28:28 -05:00
dakkar
e4047b4076 rethrow everything but non-retryable HTTP errors
every job that ends without an exception will be considered
"completed" and not retried
2024-12-22 15:28:21 -05:00
dakkar
5eca807e19 merge: Revert "Synchronize server startup" (!831)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/831

Approved-by: dakkar <dakkar@thenautilus.net>
Approved-by: Charlotte <timo.herngreen@gmail.com>
2024-12-21 16:35:51 +00:00
dakkar
0c123d04d6 merge: Sync charts one-at-a-time to reduce database contention and timeouts (!830)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/830

Approved-by: dakkar <dakkar@thenautilus.net>
Approved-by: Charlotte <timo.herngreen@gmail.com>
2024-12-21 16:35:44 +00:00
bunnybeam
9160ede4d5
replace RE2 with RegExp for regex word mute validation 2024-12-21 01:34:56 +00:00
Hazelnoot
4e422836dd merge: Fix the ascii art (!835)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/835

Approved-by: dakkar <dakkar@thenautilus.net>
Approved-by: Hazelnoot <acomputerdog@gmail.com>
2024-12-20 22:35:15 +00:00
CenTdemeern1
eb21b13e73 Fix the ascii art
I should really make a new one from scratch sometime
2024-12-20 02:58:35 +01:00
Kio!
903b2be132 Update file worker.ts 2024-12-19 19:20:57 +00:00
Kio!
0bb61fef7b Update file worker.ts 2024-12-19 19:11:52 +00:00
Kio!
cdc11df562 Add missing imports before Dakkar can mention it 2024-12-19 19:07:04 +00:00
Kio!
990388141c Add Meta, oops 2024-12-19 19:01:14 +00:00
Hazelnoot
0de93c2bde only attach file extension for browser-safe file types 2024-12-19 12:33:11 -05:00
Kio!
ba9f7f42d2 Add Release version to sentry logging 2024-12-19 17:30:22 +00:00
Hazelnoot
465c780a04 Revert "Synchronize server startup"
This reverts commit ffbdfa9123.
2024-12-19 11:22:54 -05:00
Hazelnoot
ad63f55a0f add file extension to locally-stored media 2024-12-19 11:22:26 -05:00
Hazelnoot
05ff9ae93f check for cross-domain redirects that bounce from an allowed domain to a blocked domain 2024-12-18 10:29:25 -05:00
Marie
16822639e6 merge: enforce restrictions for user's rss feed (!822)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/822

Approved-by: Charlotte <timo.herngreen@gmail.com>
Approved-by: Marie <github@yuugi.dev>
2024-12-17 21:46:10 +00:00
dakkar
f4537e7092 better name, and other tweaks 2024-12-17 16:45:56 +00:00
Hazelnoot
0b40f2734e sync charts one-at-a-time to reduce database contention and timeouts 2024-12-17 10:37:29 -05:00
dakkar
799cc0d098 pick lints 2024-12-17 10:06:30 +00:00
dakkar
46432161b8 enforce restrictions for user's rss feed
if `requireSigninToViewContents` in on, no notes are included in the
feed

notes covered by `makeNotesFollowersOnlyBefore` and
`makeNotesHiddenBefore` are skipped
2024-12-17 09:47:32 +00:00
Marie
e50ff9db6a
upd: make schedule time work cross timezones 2024-12-15 22:41:16 +01:00
dakkar
e2352839e4 merge: upstream changes for 2024.11 (!742)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/742

Closes #645 and #646

Approved-by: Hazelnoot <acomputerdog@gmail.com>
Approved-by: Marie <github@yuugi.dev>
2024-12-15 17:27:12 +00:00
Hazelnoot
fd0ecb22cf merge: Fix rate limits under multi-node environments (!809)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/809

Approved-by: dakkar <dakkar@thenautilus.net>
Approved-by: Marie <github@yuugi.dev>
2024-12-15 16:53:48 +00:00
JeDaYoshi
535e0c69ce
Fix notifications breaking due to deleted role being assigned 2024-12-13 16:49:19 -04:00
dakkar
9b1fc96908 fix passing rate limiting info via ApiError 2024-12-13 16:18:10 +00:00
dakkar
0c1dd73341 on 429, retry fetchAccount instead of failing
when switching between accounts, with many tabs open (10 seem to be
enough), they all hit the endpoint at the same time, and some get rate
limited.

treating a 429 as a fatal error confuses the frontend, which ends up
logging the user out of all their accounts.

this code makes the frontend retry, after waiting the appropriate
amount of time.

seems to work fine in my testing.
2024-12-13 16:18:10 +00:00
dakkar
e9f68ab2b0 actually publish profile updates with changes to new mk fields
I had forgotten to check these
2024-12-12 17:40:22 +00:00
dakkar
b266a5f9f6 Merge branch 'develop' into feature/2024.10 2024-12-12 17:38:29 +00:00
Hazelnoot
34c5a3a3b6 fix WebhookTestService.ts 2024-12-12 08:13:47 -05:00
Hazelnoot
d95ec3de5f fix declaration of User.enableRss property 2024-12-12 08:13:47 -05:00
Hazelnoot
1c65f23445 safer typings for userNeedsPublishing and profileNeedsPublishing 2024-12-12 08:13:44 -05:00
Hazelnoot
02b600c9da federate profile when changing enableRss value 2024-12-12 08:12:44 -05:00
Hazelnoot
fe37aa2ce8 Add "enable RSS" user privacy toggle 2024-12-12 08:11:55 -05:00
dakkar
943c6414d8 merge: Enable by default and federate "hide online status" (resolves #823) (!807)
View MR for information: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/807

Closes #823

Approved-by: Marie <github@yuugi.dev>
Approved-by: dakkar <dakkar@thenautilus.net>
2024-12-12 13:08:19 +00:00
dakkar
6d4ae93592 Merge branch 'develop' into feature/2024.10 2024-12-12 13:04:51 +00:00
Hazelnoot
00c4637b11 federate profile when hideOnlineStatus changes 2024-12-12 07:34:14 -05:00
おさむのひと
9a44b37d03 fix(backend): アドレス入力で直接ユーザのプロフィールページを表示した際、前提データが足りず描画に失敗する (#15033)
* fix(backend): アドレス入力で直接ユーザのプロフィールページを表示した際、前提データが足りず描画に失敗する

* fix CHANGELOG.md
2024-12-12 10:47:02 +00:00
Hazelnoot
755ff8783b clarify naming of legacy rate limit methods 2024-12-11 14:07:25 -05:00
Hazelnoot
72d18602d8 fix SkRateLimiterService tests 2024-12-11 14:07:14 -05:00
Hazelnoot
1377873b1d fix typos and wording in SkRateLimiterService.md 2024-12-11 11:16:30 -05:00
Hazelnoot
0f5c78a69b increase chart rate limits (fixes 429s in control panel / info pages) 2024-12-11 09:10:56 -05:00
Hazelnoot
0ea9d6ec5d use atomic variant of Leaky Bucket for safe concurrent rate limits 2024-12-11 09:10:11 -05:00