Commit graph

3190 commits

Author SHA1 Message Date
Jake Potrebic
653a12cc46 Add missing key files and cleanup registry definition order 2024-09-23 17:36:29 -07:00
Jake Potrebic
660700a1d3 make MenuType implement FeatureDependant 2024-09-23 15:03:52 -07:00
Jake Potrebic
f137f3cf13 Only call EntityPortalExitEvent if entity is actually in a portal 2024-09-22 14:35:04 -07:00
Jake Potrebic
802cb228d7 Expand out datapack API (#10828)
* Expand out datapack API

* add getTitle

* better enable check
2024-09-22 14:28:45 -07:00
TreemanKing
8f59e0a8a4 Fix Color Particle API (#10895)
* fix: check datatype of particles rather than particle-type

* feature: add ARGB channels

It keeps the functionality of the original color(int).

* fix: order

* fixes

---------

Co-authored-by: Jake Potrebic <jake.m.potrebic@gmail.com>
2024-09-23 07:06:40 +10:00
Nassim Jahnke
300db3cfd0 Fixup command precprocess cancellation (#11424) 2024-09-22 21:25:37 +02:00
Nassim Jahnke
e53a1f5e22 Add ItemStack array serialization methods (#10387) 2024-09-22 21:02:06 +02:00
Oliver Janka
36472a9173 Add velocity forwarding secret env override (#10127)
Previously, the velocity forwarding secret could only be configured via
the configuration option in the global paper configuration.
This makes configuring/passing such a value rather difficult for
containerized/orchestrated servers as these configuration files are
usually part of the server data volume itself and hence cannot be
sourced from a secret.

This commit enables administrators to define the PAPER_VELOCITY_SECRET
environment variable, which will override any potentially configured
velocity secret.
2024-09-22 20:25:27 +02:00
Bjarne Koll
e371c168d8 Deprecate BlockType#isInteractable (#11427)
While BlockType is still marked as internal, it mirrors the already
paper-deprecated method #isInteractable.

The commit marks said method as deprecated if/when BlockType becomes
experimental/non-internal.
2024-09-22 20:09:41 +02:00
Lulu13022002
b54562400c Update launchProjectile API (#11300) 2024-09-21 21:19:02 +02:00
Jake Potrebic
5b9ea906ed Create TileStateInventoryHolder (#11420)
Adds a missing interface to centralize getSnapshotInventory methods.
2024-09-21 11:09:29 -07:00
Bjarne Koll
a3916fd4da Correctly launch WindCharges (#11418)
The launch API on LivingEntity only respected the WindCharge type, not
its near-clone BreezeWindCharge.

This commit correctly accounts for BreezeWindCharge in
CraftLivingEntity.
2024-09-21 20:08:31 +02:00
Newwind
2bb8e69297 Disable pretty printing for advancement saving (#11419) 2024-09-21 19:01:22 +01:00
Bjarne Koll
1b174804c7 Return null in getRegistry(Class) for unknown type (#11422)
The Bukkit#getRegistry(Class) method contract specifies that it returns
null for unknown registry types. The current implementation however
requires the passed class to be mappable to a known registry key.

For types like Material, which have a SimpleRegistry in bukkit's
Registry interface, no server side registry exists and such the type
cannot be mapped to a registry key.

The commit correctly returns null for types that are not mappable to a
registry key instead of throwing a NullPointerException.
2024-09-21 19:57:08 +02:00
Bjarne Koll
f65939c6bd Remove wall-time / unused skip tick protection (#11412)
Spigot still maintains some partial implementation of "tick skipping", a
practice in which the MinecraftServer.currentTick field is updated not
by an increment of one per actual tick, but instead set to
System.currentTimeMillis() / 50. This behaviour means that the tracked
tick may "skip" a tick value in case a previous tick took more than the
expected 50ms.

To compensate for this in important paths, spigot/craftbukkit
implements "wall-time". Instead of incrementing/decrementing ticks on
block entities/entities by one for each call to their tick() method,
they instead increment/decrement important values, like
an ItemEntity's age or pickupDelay, by the difference of
`currentTick - lastTick`, where `lastTick` is the value of
`currentTick` during the last tick() call.

These "fixes" however do not play nicely with minecraft's simulation
distance as entities/block entities implementing the above behaviour
would "catch up" their values when moving from a non-ticking chunk to a
ticking one as their `lastTick` value remains stuck on the last tick in
a ticking chunk and hence lead to a large "catch up" once ticked again.

Paper completely removes the "tick skipping" behaviour (See patch
"Further-improve-server-tick-loop"), making the above precautions
completely unnecessary, which also rids paper of the previous described
incompatibility with non-ticking chunks.
2024-09-19 16:36:07 +02:00
Shane Freeder
5d6137bcc9 Only mark decorations dirty if a removal actually occurs (#11413)
* Only mark decorations dirty if a removal actually occurs

Vanilla calls this method blindly inside of a loop which erroniously marks
map data files as being dirty even if nothing has actually changed.

* Merge into existing patch

---------

Co-authored-by: Bjarne Koll <git@lynxplay.dev>
2024-09-19 15:27:33 +01:00
4real
d90c4f37f6 Validate slot in PlayerInventory#setSlot (#11399) 2024-09-17 17:57:32 +03:00
Bjarne Koll
85d19c8d5b Prevent NPE when serializing unresolved profile (#11407)
In the recent upstream update, the paper player profile was updated to
correctly return null for both name and id if constructed as such. This
change however broke the serialisation logic, as it depended on the name
never being null.

The commit moves the checks over to the newly introduced emptyName/UUID
fields that track if the profile was constructed with a null name or
uuid to differentiate it against an empty string or the NIL_UUID.
2024-09-16 20:53:00 +02:00
Tamion
8569d1f04b Fix enable-player-collisions playing sounds when set to false (#11390) 2024-09-15 22:26:23 +02:00
Tamion
11d73159d4 Fix TrialSpawner forgetting assigned mob when placed by player (#11381) 2024-09-15 22:20:38 +02:00
Jake Potrebic
7669a1097e Set default drop behavior for player deaths (#11380) 2024-09-15 12:51:35 -07:00
Bjarne Koll
aee3dfd092 Updated Upstream (Bukkit/CraftBukkit/Spigot) (#11405)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
1fc1020a PR-1049: Add MenuType API
8ae2e3be PR-1055: Expand riptiding API
cac68bfb SPIGOT-7890: AttributeModifier#getUniqueId() doesn't match the UUID passed to its constructor
7004fcf2 SPIGOT-7886: Fix mistake in AttributeModifier UUID shim
1ac7f950 PR-1054: Add FireworkMeta#hasPower
4cfb565f SPIGOT-7873: Add powered state for skulls

CraftBukkit Changes:
bbb30e7a8 SPIGOT-7894: NPE when sending tile entity update
ba21e9472 SPIGOT-7895: PlayerItemBreakEvent not firing
0fb24bbe0 SPIGOT-7875: Fix PlayerItemConsumeEvent cancellation causing client-side desync
815066449 SPIGOT-7891: Can't remove second ingredient of MerchantRecipe
45c206f2c PR-1458: Add MenuType API
19c8ef9ae SPIGOT-7867: Merchant instanceof AbstractVillager always returns false
4e006d28f PR-1468: Expand riptiding API
bd8aded7d Ignore checks in CraftPlayerProfile for ResolvableProfile used in profile components
8679620b5 SPIGOT-7889: Fix tool component deserialisation without speed and/or correct-for-drops
8d5222691 SPIGOT-7882, PR-1467: Fix conversion of name in Profile Component to empty if it is missing
63f91669a SPIGOT-7887: Remove duplicate ProjectileHitEvent for fireballs
7070de8c8 SPIGOT-7878: Server#getLootTable does not return null on invalid loot table
060ee6cae SPIGOT-7876: Can't kick player or disconnect player in PlayerLoginEvent when checking for cookies
7ccb86cc0 PR-1465: Add FireworkMeta#hasPower
804ad6491 SPIGOT-7873: Add powered state for skulls
f9610cdcb Improve minecart movement

Spigot Changes:
a759b629 Rebuild patches

Co-authored-by: Jake Potrebic <jake.m.potrebic@gmail.com>
2024-09-15 21:39:53 +02:00
Nassim Jahnke
2ac5a53f6b Update spark 2024-09-12 19:54:34 +02:00
Jason Penilla
0b7b70d405 Fix PaperServerListPingEvent#getPlayerSample not being populated or used (#11387) 2024-09-10 10:52:30 -07:00
Jake Potrebic
d503cbe01f deprecate isEnabledByFeature in Item/BlockType 2024-09-09 19:19:46 -07:00
Fabrizio La Rosa
5bfe411ab7 Add Decorated Pot Cracked API (#11365) 2024-09-08 22:12:36 +02:00
masmc05
988b902234 Add Item serialization as json api (#11235)
* Item serialization as json

* Add ItemStackAdapter for Gson

* A javadoc note at #serialize() and #deserialize()

* Rebase

* Move serialize closer to deserialize

* Add explaining comment about SERIALIZE_CUSTOM_AS_SNBT usage

* Apply lynxplay requests

* Forgot `@NotNull`

* Very important diff was removed

* Rebase

* Javadocs

---------

Co-authored-by: Bjarne Koll <git@lynxplay.dev>
2024-09-08 22:58:30 +03:00
Jake Potrebic
969432263f Tag Lifecycle Events (#10993)
* wip tags

* use generics in tag registrars

* comment out varargs methods for now

* split up patch

* cache loaded service provider

* finish renames

* use builderWithExpectedSize

* finalize
2024-09-08 11:56:09 -07:00
Nassim Jahnke
a21216b976 Update Velocity natives again
If you segfault, update your jre/jdk™️
2024-09-08 20:39:00 +02:00
Jake Potrebic
d1190734bc Enchantment is data-driven, so not FeatureDependant (#11377) 2024-09-08 10:42:44 -07:00
Jake Potrebic
fc2cdc7db9 Add FeatureFlag API (#8952)
* Add FeatureFlag API

* switch to index & move method

* fix test
2024-09-07 13:35:11 -07:00
Jake Potrebic
b91a342aa2 Deprecate for removal all OldEnum-related methods (#11371) 2024-09-07 13:02:45 -07:00
Jake Potrebic
2c264ee7c0 Fix shulkerbox loot table replenish (#11366)
* Fix shulkerbox loot table replenish

* re-add loot table if cleared

* add config
2024-09-07 12:49:28 -07:00
Pedro
83ba6295a8 Fix NPE while trying to respawn an already disconnected player (#11353) 2024-09-07 15:34:03 -04:00
Bjarne Koll
9d935c67e6 Revert velocity natives to 3.1.2 (#11368)
The updated velocity native compilation pipeline seems to emit binaries
that are not compatible with alpine.
The commit temporarily reverts the natives included until a proper
solution is found.
2024-09-07 11:00:57 +02:00
Newwind
4a8d483d21 Check dead flag in isAlive() (#11330)
* Create 1055-Check-dead-flag-in-isAlive().patch

* Rebase
2024-09-06 23:06:32 +01:00
Lulu13022002
5217983dca Fix allowSpiderWorldBorderClimbing world config (#11321) 2024-09-06 23:15:29 +02:00
Jake Potrebic
d668e93940 Improve console completion with brig suggestions (#9251)
* Improve console completion with brig suggestions

* silence warning

* small fixes

* squashed
2024-09-06 13:37:09 -07:00
VelVeV
5bf1879bed Change condition check order of entity tracking Y (#11348) 2024-09-07 05:14:20 +09:00
nathannm23
5ff3e52f47 Fire BlockExpEvent on grindstone use (#11346) 2024-09-06 14:14:10 -06:00
VelVeV
9ffce8d935 Update Velocity natives (#11347) 2024-09-07 04:44:24 +09:00
lucko
303dbb3695 Fix bundled spark permission check (#11355) 2024-09-06 20:41:54 +01:00
Nassim Jahnke
daecf055f5 Use reference hash set in reference Holder (#11363) 2024-09-06 21:03:17 +02:00
Space Walker
3f3175814b Update Alternate Current to v1.9 (#11333) 2024-09-01 19:59:20 +02:00
Tamion
eb3c4a33e7 Fix inventory desync when placing blocks with spawn protection (#11090)
* fix

* mention mojira issue

* move to vanilla bug fixes patch

---------

Co-authored-by: Jake Potrebic <jake.m.potrebic@gmail.com>
2024-08-31 21:01:29 +02:00
Tamion
4e20fc68d1 Fix InventoryOpenEvent cancellation (#11304)
* fix

* other blocks

* add missing diff in ContainerEntity

---------

Co-authored-by: Jake Potrebic <jake.m.potrebic@gmail.com>
2024-08-31 20:50:24 +02:00
Newwind
973bb47949 Fix horse armor desync (#11341) 2024-08-31 19:29:50 +01:00
Jason Penilla
5b96be4ce6 Fixup porting issue in vanillaBiomeProvider impl (#11185) 2024-08-31 10:59:17 -07:00
Gegy
dc8d16ed3d Fix: synchronise sending chat to client with updating message signature cache (#11332)
In the case where multiple messages from different players are being processed in parallel, there was a potential race condition where the messages would be sent to the client in a different order than the message signature cache was updated. However, the cache relies on the fact that the client and server get the exact same updates in the same order. This race condition would cause the caches to become corrupted, and any future message received by the client would fail to validate.

This also applies to the last seen state of the server, which becomes inconsistent in the same way as the message signature cache and would cause any messages sent to be rejected by the server too.
2024-08-26 19:53:28 +02:00
Lulu13022002
e24e14e58d Re-implement maxLeashDistance world conf and call missing event (#11301)
* Re-implement maxLeashDistance world config and call missing event

* migrate config setting to double or default

* fixes

---------

Co-authored-by: Jake Potrebic <jake.m.potrebic@gmail.com>
2024-08-25 23:32:32 +02:00
okx-code
4a97c636b7 Add enchantment seed update API (#11282) 2024-08-25 21:39:06 +01:00
Isaac - The456
a41ced0e65 Ensure TabCompleteEvent always has a mutable backing list. (#11302) 2024-08-25 21:28:32 +01:00
DerEchtePilz
900192b490 Add a method to reset Lodestone compasses back to normal ones (#11308) 2024-08-25 22:25:13 +02:00
DerEchtePilz
2fa1146af5 Properly destroy placed blocks on the end platform (#11292) 2024-08-25 21:19:40 +02:00
Jake Potrebic
0481feec57 Deprecate API relating to menu title changes (#11309) 2024-08-25 11:56:17 -07:00
Jake Potrebic
43f2d628d5 Fix despawn ranges by defaulting to an ellipsoid shape (#11312) 2024-08-25 11:26:33 -07:00
Newwind
4a0660bd59 Remove set damage lootable item function from compasses (#11317) 2024-08-25 18:52:12 +01:00
Newwind
acf0b2d2f1 Fix incorrect timestamp in region file header recalculation (#11318) 2024-08-25 18:42:15 +01:00
Lulu13022002
403db04ae4 Prevent duplicate pickup event for piglins (#11322) 2024-08-25 19:27:31 +02:00
Janet Blackquill
5f317598d4 Ensure MaterialChoice materials are items (#11325) 2024-08-25 13:20:10 -04:00
Nassim Jahnke
50b7f46507 Update spark-paper 2024-08-24 10:52:38 +02:00
roro1506HD
80501c393a Fix structure check API (#11307)
* Fix structure check API

* Use CraftStructure#bukkitToMinecraft

* Fixed spelling mistake on CraftStructure class name
2024-08-21 03:27:33 +02:00
Jake Potrebic
01e05f9751 Fix SculkBloomEvent firing for block entity loading (#11306) 2024-08-19 14:28:03 -07:00
Nassim Jahnke
4034116f05 Fixup config parsing 2024-08-19 12:47:50 +02:00
DerEchtePilz
d80cafec08 [ci skip] Fix JavaDocs for HeightMap#MOTION_BLOCKING_NO_LEAVES (#11291) 2024-08-19 11:48:20 +02:00
Anthony J. Halliday
3ab4933ea3 Allow server administrators to disable book size checks (#10457) 2024-08-19 05:46:39 -04:00
kokiriglade
9921a197e7 Add getWorld method that uses adventure Key (#11199) 2024-08-19 10:41:55 +01:00
Nassim Jahnke
5703e6c6d8 [ci skip] Clean up book limits patch (#11297) 2024-08-19 11:33:17 +02:00
Spottedleaf
9804f7ffe1 Use player file, not directory, when checking for offline player data
When trying to fall back to offline player data in onlide mode,
we need to use the player file. This fixes a mistake during
update where 'file' was used, but the new code uses 'file1'
for the player file.
2024-08-18 15:32:25 -07:00
Spottedleaf
9ceadbe9f1 Fix entity limit patch deleting unnecessary entities
We need to continue the save loop, not break from it
when a limit is reached.
2024-08-18 11:14:39 -07:00
SoSeDiK
1f6969e350 Allow getting/setting the sign's editor uuid (#10637)
* Allow getting/setting the sign's editor uuid

* rebased

---------

Co-authored-by: Jake Potrebic <jake.m.potrebic@gmail.com>
2024-08-18 00:36:27 +03:00
Tamion
0f622bb732 Fix CraftBukkit drag system (#10703) 2024-08-17 23:31:38 +02:00
Isaac - The456
659f0f2fd0 Fix Selector Arguments not working with permission (#11286) 2024-08-17 22:20:21 +01:00
Lulu13022002
6da54bd440 Leashable API (#10961) 2024-08-17 23:17:18 +02:00
Jake Potrebic
0df31bdeb3 Add even more Enchantment API (#11115) 2024-08-17 13:58:36 -07:00
Lulu13022002
0a041c951d Update item data sanitization (#11227) 2024-08-17 22:30:21 +02:00
Jake Potrebic
c10949d863 Updated Upstream (Bukkit/CraftBukkit/Spigot) (#11284)
Updated Upstream (Bukkit/CraftBukkit/Spigot)

Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
4068c6aa PR-1053: Change docs for max power in FireworkMeta
6b3c241b SPIGOT-7783, SPIGOT-7784, PR-1051: Add Trial Vault & Spawner event API
5fe300ec PR-1052: Fix broken links and minor improvement for checkstyle.xml

CraftBukkit Changes:
7548afcf2 SPIGOT-7872: Fix crash with event-modified teleports
93480d5d6 SPIGOT-7868, PR-1463: Fix default and max power in FireworkMeta
5060d1a84 SPIGOT-7783, SPIGOT-7784, PR-1460: Add Trial Vault & Spawner event API
11dfcae71 PR-1462: Fix broken links and minor improvement for checkstyle.xml

Spigot Changes:
ca581228 Rebuild patches
2024-08-17 12:39:11 -07:00
Tamion
da11f251cd Add Configuration for vertical Despawn Ranges (#11279) 2024-08-17 21:13:10 +02:00
Shane Freeder
d0221fe540 Migrate ArmorStand meta to using entity tag (#11107) 2024-08-16 23:30:11 +01:00
Lulu13022002
f011be78fc Implement more methods for horse inventories (#11147) 2024-08-17 00:27:47 +02:00
Lulu13022002
d44aa26792 Handle custom registry elements properly (#11230)
* Handle custom registry elements properly

* update error message

Datapack made painting variant support is added in https://github.com/PaperMC/Paper/pull/11244

* change msg for art conversion

---------

Co-authored-by: Jake Potrebic <jake.m.potrebic@gmail.com>
2024-08-16 23:21:35 +02:00
Lulu13022002
0c47bf87a2 Re-implement portalCreateRadius world config (#11267) 2024-08-16 22:59:46 +02:00
Mart
d0fb407064 Allow skipping of world symlink validation (#11250) 2024-08-16 16:36:30 -04:00
Bjarne Koll
8ffc76800a [ci-skip] Revert "Add Configuration for vertical Despawn Ranges (#10440)" (#11278)
This reverts commit 258b830f5e.
2024-08-16 22:33:52 +02:00
Tamion
258b830f5e Add Configuration for vertical Despawn Ranges (#10440) 2024-08-16 22:29:53 +02:00
Abel
c1b2a34de3 Fix indestructable light blocks (#11275)
Co-authored-by: Bjarne Koll <git@lynxplay.dev>
2024-08-16 22:13:00 +02:00
Lulu13022002
42dae8d83e Fix scanForLegacyEnderDragon world config (#11262) 2024-08-16 21:45:07 +02:00
Spottedleaf
1d4d2dc5f9 Apply optimise collision checking in move packet handling patch 2024-08-16 06:56:13 -07:00
Lulu13022002
fee33bd1e2 Fix NPE for PlayerPostRespawnEvent#getRespawnedLocation (#11268) 2024-08-16 09:20:57 +02:00
Lulu13022002
815149208d Fix disableEndCredits world config (#11261) 2024-08-14 21:26:38 +02:00
hyperdefined
fe4996a080 Fix TooltipContext.create being wrong(#11254)
Co-authored-by: Jake Potrebic <jake.m.potrebic@gmail.com>
2024-08-14 08:39:45 -04:00
Nassim Jahnke
f05a7d0a96 Improve standard messenger logging 2024-08-12 18:42:08 +02:00
Jake Potrebic
23550ec960 Fix BasicCommand suggestion arg count (#11241) 2024-08-12 00:40:39 -07:00
hyperdefined
dada30ee8a Fix setSendViewDistance's return (#11247) 2024-08-12 03:27:27 -04:00
Jake Potrebic
0625ce9d09 [ci skip] Fix Effect javadocs (#11182) 2024-08-11 15:35:45 -07:00
Lulu13022002
4c7b6f5c05 Remove arbitrary book page limit (#11228) 2024-08-12 00:30:23 +02:00
Newwind
794e2754b5 Configuration for horizontal-only item merging (#11219) 2024-08-11 23:16:20 +01:00
Jake Potrebic
3cb3616012 Re-add patches for can-place/can-destroy API (#11238)
* Re-add patches for can-place/can-destroy API

This API is all deprecated for removal and has to be replaced
as the structure of it has too radically changed

* update patches

* add link to MaterialRerouting

* Deprecation

---------

Co-authored-by: Bjarne Koll <git@lynxplay.dev>
2024-08-11 13:51:37 -07:00
Jake Potrebic
b366872963 Fix teleport event getTo returning null (#11239) 2024-08-11 13:42:39 -07:00
Jake Potrebic
e574dc326d Correctly check enchants for ItemStack#damage (#11240) 2024-08-11 13:27:24 -07:00