Commit graph

2862 commits

Author SHA1 Message Date
Jake Potrebic
d668e93940 Improve console completion with brig suggestions (#9251)
* Improve console completion with brig suggestions

* silence warning

* small fixes

* squashed
2024-09-06 13:37:09 -07:00
VelVeV
5bf1879bed Change condition check order of entity tracking Y (#11348) 2024-09-07 05:14:20 +09:00
nathannm23
5ff3e52f47 Fire BlockExpEvent on grindstone use (#11346) 2024-09-06 14:14:10 -06:00
VelVeV
9ffce8d935 Update Velocity natives (#11347) 2024-09-07 04:44:24 +09:00
lucko
303dbb3695 Fix bundled spark permission check (#11355) 2024-09-06 20:41:54 +01:00
Nassim Jahnke
daecf055f5 Use reference hash set in reference Holder (#11363) 2024-09-06 21:03:17 +02:00
Space Walker
3f3175814b Update Alternate Current to v1.9 (#11333) 2024-09-01 19:59:20 +02:00
Tamion
eb3c4a33e7 Fix inventory desync when placing blocks with spawn protection (#11090)
* fix

* mention mojira issue

* move to vanilla bug fixes patch

---------

Co-authored-by: Jake Potrebic <jake.m.potrebic@gmail.com>
2024-08-31 21:01:29 +02:00
Tamion
4e20fc68d1 Fix InventoryOpenEvent cancellation (#11304)
* fix

* other blocks

* add missing diff in ContainerEntity

---------

Co-authored-by: Jake Potrebic <jake.m.potrebic@gmail.com>
2024-08-31 20:50:24 +02:00
Newwind
973bb47949 Fix horse armor desync (#11341) 2024-08-31 19:29:50 +01:00
Jason Penilla
5b96be4ce6 Fixup porting issue in vanillaBiomeProvider impl (#11185) 2024-08-31 10:59:17 -07:00
Gegy
dc8d16ed3d Fix: synchronise sending chat to client with updating message signature cache (#11332)
In the case where multiple messages from different players are being processed in parallel, there was a potential race condition where the messages would be sent to the client in a different order than the message signature cache was updated. However, the cache relies on the fact that the client and server get the exact same updates in the same order. This race condition would cause the caches to become corrupted, and any future message received by the client would fail to validate.

This also applies to the last seen state of the server, which becomes inconsistent in the same way as the message signature cache and would cause any messages sent to be rejected by the server too.
2024-08-26 19:53:28 +02:00
Lulu13022002
e24e14e58d Re-implement maxLeashDistance world conf and call missing event (#11301)
* Re-implement maxLeashDistance world config and call missing event

* migrate config setting to double or default

* fixes

---------

Co-authored-by: Jake Potrebic <jake.m.potrebic@gmail.com>
2024-08-25 23:32:32 +02:00
okx-code
4a97c636b7 Add enchantment seed update API (#11282) 2024-08-25 21:39:06 +01:00
DerEchtePilz
900192b490 Add a method to reset Lodestone compasses back to normal ones (#11308) 2024-08-25 22:25:13 +02:00
DerEchtePilz
2fa1146af5 Properly destroy placed blocks on the end platform (#11292) 2024-08-25 21:19:40 +02:00
Jake Potrebic
43f2d628d5 Fix despawn ranges by defaulting to an ellipsoid shape (#11312) 2024-08-25 11:26:33 -07:00
Newwind
4a0660bd59 Remove set damage lootable item function from compasses (#11317) 2024-08-25 18:52:12 +01:00
Newwind
acf0b2d2f1 Fix incorrect timestamp in region file header recalculation (#11318) 2024-08-25 18:42:15 +01:00
Lulu13022002
403db04ae4 Prevent duplicate pickup event for piglins (#11322) 2024-08-25 19:27:31 +02:00
Nassim Jahnke
50b7f46507 Update spark-paper 2024-08-24 10:52:38 +02:00
roro1506HD
80501c393a Fix structure check API (#11307)
* Fix structure check API

* Use CraftStructure#bukkitToMinecraft

* Fixed spelling mistake on CraftStructure class name
2024-08-21 03:27:33 +02:00
Jake Potrebic
01e05f9751 Fix SculkBloomEvent firing for block entity loading (#11306) 2024-08-19 14:28:03 -07:00
Nassim Jahnke
4034116f05 Fixup config parsing 2024-08-19 12:47:50 +02:00
Anthony J. Halliday
3ab4933ea3 Allow server administrators to disable book size checks (#10457) 2024-08-19 05:46:39 -04:00
kokiriglade
9921a197e7 Add getWorld method that uses adventure Key (#11199) 2024-08-19 10:41:55 +01:00
Nassim Jahnke
5703e6c6d8 [ci skip] Clean up book limits patch (#11297) 2024-08-19 11:33:17 +02:00
Spottedleaf
9804f7ffe1 Use player file, not directory, when checking for offline player data
When trying to fall back to offline player data in onlide mode,
we need to use the player file. This fixes a mistake during
update where 'file' was used, but the new code uses 'file1'
for the player file.
2024-08-18 15:32:25 -07:00
Spottedleaf
9ceadbe9f1 Fix entity limit patch deleting unnecessary entities
We need to continue the save loop, not break from it
when a limit is reached.
2024-08-18 11:14:39 -07:00
SoSeDiK
1f6969e350 Allow getting/setting the sign's editor uuid (#10637)
* Allow getting/setting the sign's editor uuid

* rebased

---------

Co-authored-by: Jake Potrebic <jake.m.potrebic@gmail.com>
2024-08-18 00:36:27 +03:00
Tamion
0f622bb732 Fix CraftBukkit drag system (#10703) 2024-08-17 23:31:38 +02:00
Isaac - The456
659f0f2fd0 Fix Selector Arguments not working with permission (#11286) 2024-08-17 22:20:21 +01:00
Lulu13022002
6da54bd440 Leashable API (#10961) 2024-08-17 23:17:18 +02:00
Jake Potrebic
0df31bdeb3 Add even more Enchantment API (#11115) 2024-08-17 13:58:36 -07:00
Lulu13022002
0a041c951d Update item data sanitization (#11227) 2024-08-17 22:30:21 +02:00
Jake Potrebic
c10949d863 Updated Upstream (Bukkit/CraftBukkit/Spigot) (#11284)
Updated Upstream (Bukkit/CraftBukkit/Spigot)

Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
4068c6aa PR-1053: Change docs for max power in FireworkMeta
6b3c241b SPIGOT-7783, SPIGOT-7784, PR-1051: Add Trial Vault & Spawner event API
5fe300ec PR-1052: Fix broken links and minor improvement for checkstyle.xml

CraftBukkit Changes:
7548afcf2 SPIGOT-7872: Fix crash with event-modified teleports
93480d5d6 SPIGOT-7868, PR-1463: Fix default and max power in FireworkMeta
5060d1a84 SPIGOT-7783, SPIGOT-7784, PR-1460: Add Trial Vault & Spawner event API
11dfcae71 PR-1462: Fix broken links and minor improvement for checkstyle.xml

Spigot Changes:
ca581228 Rebuild patches
2024-08-17 12:39:11 -07:00
Tamion
da11f251cd Add Configuration for vertical Despawn Ranges (#11279) 2024-08-17 21:13:10 +02:00
Shane Freeder
d0221fe540 Migrate ArmorStand meta to using entity tag (#11107) 2024-08-16 23:30:11 +01:00
Lulu13022002
f011be78fc Implement more methods for horse inventories (#11147) 2024-08-17 00:27:47 +02:00
Lulu13022002
d44aa26792 Handle custom registry elements properly (#11230)
* Handle custom registry elements properly

* update error message

Datapack made painting variant support is added in https://github.com/PaperMC/Paper/pull/11244

* change msg for art conversion

---------

Co-authored-by: Jake Potrebic <jake.m.potrebic@gmail.com>
2024-08-16 23:21:35 +02:00
Lulu13022002
0c47bf87a2 Re-implement portalCreateRadius world config (#11267) 2024-08-16 22:59:46 +02:00
Mart
d0fb407064 Allow skipping of world symlink validation (#11250) 2024-08-16 16:36:30 -04:00
Bjarne Koll
8ffc76800a [ci-skip] Revert "Add Configuration for vertical Despawn Ranges (#10440)" (#11278)
This reverts commit 258b830f5e.
2024-08-16 22:33:52 +02:00
Tamion
258b830f5e Add Configuration for vertical Despawn Ranges (#10440) 2024-08-16 22:29:53 +02:00
Abel
c1b2a34de3 Fix indestructable light blocks (#11275)
Co-authored-by: Bjarne Koll <git@lynxplay.dev>
2024-08-16 22:13:00 +02:00
Lulu13022002
42dae8d83e Fix scanForLegacyEnderDragon world config (#11262) 2024-08-16 21:45:07 +02:00
Spottedleaf
1d4d2dc5f9 Apply optimise collision checking in move packet handling patch 2024-08-16 06:56:13 -07:00
Lulu13022002
fee33bd1e2 Fix NPE for PlayerPostRespawnEvent#getRespawnedLocation (#11268) 2024-08-16 09:20:57 +02:00
Lulu13022002
815149208d Fix disableEndCredits world config (#11261) 2024-08-14 21:26:38 +02:00
Nassim Jahnke
f05a7d0a96 Improve standard messenger logging 2024-08-12 18:42:08 +02:00
Jake Potrebic
23550ec960 Fix BasicCommand suggestion arg count (#11241) 2024-08-12 00:40:39 -07:00
hyperdefined
dada30ee8a Fix setSendViewDistance's return (#11247) 2024-08-12 03:27:27 -04:00
Lulu13022002
4c7b6f5c05 Remove arbitrary book page limit (#11228) 2024-08-12 00:30:23 +02:00
Newwind
794e2754b5 Configuration for horizontal-only item merging (#11219) 2024-08-11 23:16:20 +01:00
Jake Potrebic
3cb3616012 Re-add patches for can-place/can-destroy API (#11238)
* Re-add patches for can-place/can-destroy API

This API is all deprecated for removal and has to be replaced
as the structure of it has too radically changed

* update patches

* add link to MaterialRerouting

* Deprecation

---------

Co-authored-by: Bjarne Koll <git@lynxplay.dev>
2024-08-11 13:51:37 -07:00
Jake Potrebic
b366872963 Fix teleport event getTo returning null (#11239) 2024-08-11 13:42:39 -07:00
Jake Potrebic
e574dc326d Correctly check enchants for ItemStack#damage (#11240) 2024-08-11 13:27:24 -07:00
Lulu13022002
e0bec73f14 Fix wrong spawn reason for trial spawners (#11229) 2024-08-11 00:19:54 +02:00
Lulu13022002
5e68331cc3 Fix tag key generator output inconsistencies (#11218)
* Fix tag key generator output inconsistencies

* use NonNull instead of NotNull for generated api

---------

Co-authored-by: Jake Potrebic <jake.m.potrebic@gmail.com>
2024-08-11 00:11:57 +02:00
Lulu13022002
1569c093c5 Fix CraftMetaShield equality (#11232) 2024-08-10 15:08:00 +02:00
Nassim Jahnke
ec79de82ca Update to 1.21.1 2024-08-10 12:24:38 +02:00
Nassim Jahnke
f117e53094 Check shooter in configurable projectile relative velocity patch 2024-08-10 11:55:08 +02:00
Joo200
bc48955246 Fix source of knockback for spigot events (#11176) 2024-08-09 22:57:55 +02:00
Bjarne Koll
b819030e31 Updated Upstream (Bukkit/CraftBukkit/Spigot) (#11197)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
2ec53f49 PR-1050: Fix empty result check for Complex Recipes
10671012 PR-1044: Add CrafterCraftEvent
4d87ffe0 Use correct method in JavaDoc
ae5e5817 SPIGOT-7850: Add API for Bogged shear state
46b6d445 SPIGOT-7837: Support data pack banner patterns
d5d0cefc Fix JavaDoc error
b3c2b83d PR-1036: Add API for InventoryView derivatives
1fe2c75a SPIGOT-7809: Add ShieldMeta

CraftBukkit Changes:
8ee6fd1b8 SPIGOT-7857: Improve ItemMeta block data deserialization
8f26c30c6 SPIGOT-7857: Fix spurious internal NBT tag when deserializing BlockStateMeta
759061b93 SPIGOT-7855: Fire does not spread or burn blocks
00fc9fb64 SPIGOT-7853: AnvilInventory#getRepairCost() always returns 0
7501e2e04 PR-1450: Add CrafterCraftEvent
8c51673e7 SPIGOT-5731: PortalCreateEvent#getEntity returns null for nether portals ignited by flint and steel
d53d0d0b1 PR-1456: Fix inverted logic in CraftCrafterView#setSlotDisabled
682a678c8 SPIGOT-7850: Add API for Bogged shear state
fccf5243a SPIGOT-7837: Support data pack banner patterns
9c3bd4390 PR-1431: Add API for InventoryView derivatives
0cc6acbc4 SPIGOT-7849: Fix FoodComponent serialize with "using-converts-to" using null
2c5474952 Don't rely on tags for CraftItemMetas
20d107e46 SPIGOT-7846: Fix ItemMeta for hanging signs
76f59e315 Remove redundant clone in Dropper InventoryMoveItemEvent
e61a53d25 SPIGOT-7817: Call InventoryMoveItemEvent for Crafters
894682e2d SPIGOT-7839: Remove redundant Java version checks
2c12b2187 SPIGOT-7809: Add ShieldMeta and fix setting shield base colours

Spigot Changes:
fb8fb722 Rebuild patches
34bd42b7 SPIGOT-7835: Fix issue with custom hopper settings
2024-08-09 22:05:50 +02:00
Nassim Jahnke
35fd8fb960 Check for block type in SculkSensorBlock#canActivate 2024-08-07 14:34:12 +02:00
metabrix
f8f2bd7db7 Fix wrong assumption about locale being null in the login phase (#11204)
Fixes #11203
2024-08-06 00:02:19 +05:00
Nassim Jahnke
36c41877b6 Remove chunk unload trace debug
The issue the patch was initially added for has already been fixed and filling stacktraces can be expensive
2024-08-05 19:57:34 +02:00
Spottedleaf
842831a3cf ConcurrentUtil: Fix concurrent long map resize chain pull function
The function assumed that the current resize chain pointed to
the previous table, when in fact it pointed to the current table.

The function is supposed to restore the resize chain to the previous
table, previous increment, and previous index + new increment.
2024-08-01 16:55:33 -07:00
Spottedleaf
bad7a89384 Make loadChunksForMoveAsync use new chunk system load calls
This is to allow the call to work properly when on Folia,
as Folia does not have a main thread.
2024-07-30 19:50:14 -07:00
Jason Penilla
86d0c737cc Preserve command node when re-registering modern commands through old API (#11184)
* Preserve command node when re-registering modern commands through old API

* make fix more targeted

mainly because it didn't work for vanilla commands :)
2024-07-30 11:42:55 -07:00
Jason Penilla
301caeb6d0 Allow plugin aliases to override vanilla commands (#11186)
fixes #11035
2024-07-30 11:28:05 -07:00
Spottedleaf
5bb7bd0f66 Move TickThread changes from Moonrise patch to MCUtils
The common changes from Moonrise should be entirely in MCUtils
2024-07-30 05:32:20 -07:00
Shane Freeder
c58d918886 Don't entirely die just because a plugin jar was bad 2024-07-29 16:54:46 +01:00
Shane Freeder
c2b2de43cf Shutdown L4J cordially if the server stops before it's even started (#11172)
primarily, this allows us to ensure that appenders are flushed, console, log files
before the JVM exits to avoid issues such as error messages disappearing
2024-07-29 16:10:53 +01:00
Spottedleaf
e9a408f93f Add mob bucket items to item id to entity map in DataConverter
Mojang missed these in their mapping. Since the entity data
is used when spawning the bucketed mob, we need to have these
inside the id map to ensure that the entity data is converted
correctly if the entity id is missing.
2024-07-28 17:36:53 -07:00
Spottedleaf
78866a364d Do not allow chunk unloading outside of the regular tick loop
Allowing chunk loading to occur at any point via purgeUnload()
introduces possible undesirable behavior to occur recursively
inside the chunk system.
2024-07-28 16:18:25 -07:00
Spottedleaf
ce8b79d47e Null check tracker in Entity#resendPossiblyDesyncedEntityData
Accidentally dropped this check last commit. It is possible
that this is called while the entity is not tracked.
2024-07-28 15:49:38 -07:00
Spottedleaf
3badc8385a Copy missed changes to chunk system from Folia 2024-07-28 15:34:07 -07:00
Spottedleaf
08e9cfb799 Remove Entity tracker field
Now the only tracker field is from the entity tracker
optimisations.
2024-07-28 15:28:28 -07:00
Jake Potrebic
d34db05237 Add argument for FinePosition to brig API (#11094) 2024-07-28 11:23:18 -07:00
powercas_gamer
5257a97fb3 Fix Owen's typos (#11179) 2024-07-28 19:58:57 +02:00
Tamion
b624a6526d Fix PickupStatus getting reset (#11154) 2024-07-27 16:37:51 +02:00
Newwind
fff73fa4c4 Make max interaction range configurable (#11164)
The server validates incoming interaction packets by ensuring the player
sending them is inside their interaction range. For this, the server adds
a magic value, by default 1.0, to the original interaction range to
account for latency issues.

This value however may be too low in high latency environments.
The patch exposes a new configuration option to configure said value.
2024-07-27 13:18:16 +01:00
Shane Freeder
7c88512287 Bump MCUtils#asyncExecutor core size
Long ago we discovered that the default thread pools would not increase
the number of threads running the pool until queue addition failed.
Bumping the core size mitigates an issue with spark-paper, and in general,
keeping async threads around generally beats having to spin new ones
everytime we want to execute a periodic async task.
2024-07-26 13:43:48 +01:00
Lulu13022002
61ad933f4d Fix a couple of ItemMeta related NPEs (#11149) 2024-07-23 10:11:00 +02:00
Lulu13022002
1f88247729 Fix horse inventories indices (#11139) 2024-07-22 15:17:25 +02:00
Tamion
cb5526fec2 Fix EntityUnleashEvent cancellation on distance cause (#11131) 2024-07-21 12:33:37 +02:00
Riley Park
1ef619aa34 Update the bundled spark version 2024-07-20 13:56:37 -07:00
Riley Park
5ff87e597f Properly lookup plugin classes when looked up by spark
fixes #11124
2024-07-20 13:00:29 -07:00
Riley Park
de456328de Improve server startup logging (#11110)
* Improve server startup logging

* Add plugin info at startup

---------

Co-authored-by: Jason Penilla <11360596+jpenilla@users.noreply.github.com>
2024-07-20 10:36:52 -07:00
Riley Park
574485b5bd Move configuration option to a system property 2024-07-20 10:14:55 -07:00
Riley Park
bb682e9548 Bundle spark (#11093) 2024-07-20 09:35:39 -07:00
Jason Penilla
2b8d0d6df8 Adjust done message again (#11118)
what paper now shows as level loading time is the time displayed by vanilla or spigot in the 'done' message

the time in the done message is now the actual time since the servers Main class was initialized
2024-07-19 12:36:09 -07:00
Bjarne Koll
71e3c51538 Make CraftComplexRecipe extend CraftingRecipe (#11114) 2024-07-19 19:29:31 +02:00
Nassim Jahnke
66dc0ac979 Call PlayerChunkUnloadEvent 2024-07-19 13:50:38 +02:00
Nassim Jahnke
40dfd62e54 Fixup startup time log message 2024-07-19 13:38:43 +02:00
Nassim Jahnke
203314faf8 Split rewriting flag into paper.disableOldApiSupport and paper.disablePluginRemapping (#11108) 2024-07-19 13:08:08 +02:00
Bjarne Koll
4c38b7496b Add CrafterCraftEvent (#11082)
Ports the proposed CrafterCraftEvent proposed in an
open upstream PR.

See: https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit/pull-requests/1044
2024-07-19 11:21:26 +02:00
Jason Penilla
870239b8a4 Add total time to done message (#11109)
* Add total time to done message

Previously it would only show the world load time which is misleading

* Add comments
2024-07-18 15:33:14 -07:00
Nassim Jahnke
dc136446fb Even more cleanup of mcutil patch 2024-07-18 16:50:16 +02:00