Commit graph

7174 commits

Author SHA1 Message Date
Nassim Jahnke
9fdc8516b8 Update snekyaml 2022-09-26 19:47:22 +02:00
Spottedleaf
0f1a8717e8 Rewrite chunk system (#8177)
Patch documentation to come

Issues with the old system that are fixed now:
- World generation does not scale with cpu cores effectively.
- Relies on the main thread for scheduling and maintaining chunk state, dropping chunk load/generate rates at lower tps.
- Unreliable prioritisation of chunk gen/load calls that block the main thread.
- Shutdown logic is utterly unreliable, as it has to wait for all chunks to unload - is it guaranteed that the chunk system is in a state on shutdown that it can reliably do this? Watchdog shutdown also typically failed due to thread checks, which is now resolved.
- Saving of data is not unified (i.e can save chunk data without saving entity data, poses problems for desync if shutdown is really abnormal.
- Entities are not loaded with chunks. This caused quite a bit of headache for Chunk#getEntities API, but now the new chunk system loads entities with chunks so that they are ready whenever the chunk loads in. Effectively brings the behavior back to 1.16 era, but still storing entities in their own separate regionfiles.

The above list is not complete. The patch documentation will complete it.

New chunk system hard relies on starlight and dataconverter, and most importantly the new concurrent utilities in ConcurrentUtil.

Some of the old async chunk i/o interface (i.e the old file io thread reroutes _some_ calls to the new file io thread) is kept for plugin compat reasons. It will be removed in the next major version of minecraft.

The old legacy chunk system patches have been moved to the removed folder in case we need them again.
2022-09-26 01:02:51 -07:00
Bjarne Koll
614f528234 Fix typos in isTickingWorlds API javadocs (#8382) 2022-09-25 02:01:17 +02:00
Lulu13022002
f059f8fce5 Fix setEggCount method from TurtleLayEggEvent (#8385) 2022-09-24 18:34:20 +02:00
Owen1212055
aba5839fde Fix player desync on dimension change (#8253) 2022-09-24 01:45:13 -04:00
Lulu13022002
2e51143433 Avoid item meta usage for itemstack enchantment getter (#8373) 2022-09-24 07:19:51 +02:00
willkroboth
28f9b1a3cb Add method isTickingWorlds to Bukkit (#8316)
Co-authored-by: Shane Freeder <theboyetronic@gmail.com>

Also, restores un/loading worlds mid tick. This will not be officially supported API contract that such a routine is safe, and these restrictions may be restored in the future.
2022-09-24 01:19:05 -04:00
Shane Freeder
fb6addf9e6 Fix mangled patch 2022-09-24 05:48:42 +01:00
willkroboth
60fa7be5b1 Avoid potential place where the world map could be modified after its iterator is created (#8315) 2022-09-24 00:33:20 -04:00
Shane Freeder
8e18842fbc Updated Upstream (Bukkit/CraftBukkit/Spigot)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
c7c11188 SPIGOT-2620: Add Player#sendBlockChanges()
f63d2b44 Improve annotation test on parameters
3372e7b4 SPIGOT-1244, SPIGOT-6860, SPIGOT-6874: Various Javadoc and formatting fixes
a1e8a9ab PR-793: Ignore .checkstyle file generated by Eclipse IDE

CraftBukkit Changes:
c2c39089e SPIGOT-2620: Add Player#sendBlockChanges()
8209158db PR-1113: Ignore .checkstyle file generated by Eclipse IDE

Spigot Changes:
4aa5ead2 Rebuild patches
2022-09-24 02:38:12 +01:00
Jake Potrebic
d885450b81 Correct javadocs on PlayerArmorStandManipulateEvent (#7719) 2022-09-22 22:55:02 -07:00
Lulu13022002
2277da6ec5 Call BlockPhysicsEvent more often (#8264) 2022-09-23 07:35:15 +02:00
Lulu13022002
6d4edceb20 Call EntityChangeBlockEvent for frogs egg (#8136) 2022-09-23 07:32:32 +02:00
Shane Freeder
eb3f66c6da Updated Upstream (Bukkit/CraftBukkit) (#8378) 2022-09-23 06:08:43 +01:00
Jake Potrebic
ca48b2617b Updated Upstream (CraftBukkit) (#8376) 2022-09-21 17:20:59 -07:00
Jake Potrebic
99640f47f1 Fix ground pathfinding (#7683) 2022-09-20 14:06:11 -07:00
ChristopheG
bb10a5d633 Copper clear on lightning strike calls EntityChangeBlockEvent (#8126) 2022-09-20 04:35:38 +02:00
Owen1212055
d56d06cb3c Respect preventMovingIntoUnloadedChunks for optimized collision checking (#8259) 2022-09-19 22:02:52 -04:00
tahmid-23
72772baccf Fix Pathfinding After World Has Changed (#8068) 2022-09-19 21:39:46 -04:00
Nick Hensel
ad4ca0a429 Also load resources from LibraryLoader (#8335) 2022-09-20 03:07:03 +02:00
Shane Freeder
ede4468516 Make WorldCreator#keepSpawnLoaded return the WorldCreator (Fixes #8321) (#8371)
* Make WorldCreator#keepSpawnLoaded return the WorldCreator (Fixes #8321)

Thought that I fixed this before push/merge, apparently not, hence, fix
the return type and add mitigation for this.

* Fix patch/build

* Rebuild patches
2022-09-20 01:28:22 +01:00
Shane Freeder
e14a2a0cce Configurable chat thread limit (#7878) 2022-09-20 01:16:23 +01:00
Melncat
d2239c40a5 Add a consumer parameter to ProjectileSource#launchProjectile (#8374)
Co-authored-by: MelnCat <melncatuwu@gmail.com>
2022-09-19 17:03:59 -07:00
Nex
d843d7659e Added byte array serialization/deserialization for PersistentDataContainers (#7505) 2022-09-18 04:06:53 +00:00
Lulu13022002
661b30a785 Missing some effect cause (#8307) 2022-09-18 05:46:20 +02:00
Lulu13022002
d146ab42bd Missing eating regain reason (#8244) 2022-09-18 05:24:28 +02:00
Jake Potrebic
7e1f4ba55c fire EntityChangeBlockEvent in more places (#6371)
* fire EntityChangeBlockEvent in more places

* Rebuild patches

Co-authored-by: Shane Freeder <theboyetronic@gmail.com>
2022-09-17 20:03:54 -07:00
elmital
fb4e4f7a34 EndDragonFight killed statuses should be false for newly created worlds (#8354) 2022-09-18 03:44:06 +02:00
Peter Crawley
44c7404b51 Limit size of Authenticator Cache Thread Pool (#8360) 2022-09-17 22:58:51 +01:00
Fruxz
d92d75fb7b Add custom destroyerIdentity parameter to the sendBlockBreak function (#5840) 2022-09-17 23:27:46 +02:00
Bjarne Koll
0ed6315664 Properly close section storage managed files (#8364) 2022-09-17 20:50:01 +02:00
Jaren
5666320311 Stop large look changes from crashing the server (#8326) 2022-09-16 23:30:00 -04:00
karthanistyr
24d3f7bb49 Restore no-crash behaviour when read-only config file(s) (#8318) 2022-09-17 05:22:17 +02:00
Nassim Jahnke
39ae9b75e9 Updated Upstream (Bukkit/CraftBukkit/Spigot)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
9ae3f10f SPIGOT-3842: Add Player#fireworkBoost() and expand Firework API
48c0c547 PR-786: Add methods to get sounds from entities

CraftBukkit Changes:
5cc9c022a SPIGOT-7152: Handle hand item changing during air interact event
4ffa1acf6 SPIGOT-7154: Players get kicked when interacting with a conversation
4daa21123 SPIGOT-3842: Add Player#fireworkBoost() and expand Firework API
e5d6a9bbf PR-1100: Add methods to get sounds from entities
b7e9f1c8b SPIGOT-7146: Reduce use of Material switch in ItemMeta

Spigot Changes:
4c157bb4 Rebuild patches
2022-09-12 13:31:45 +02:00
Jake Potrebic
d1129b0ded Fix console completer/highlighter having invalid source stack (#8346) 2022-09-09 14:25:54 -07:00
Jake Potrebic
328360359a Updated Upstream (Bukkit/CraftBukkit/Spigot) (#8347) 2022-09-09 11:54:00 -07:00
okx-code
2cb0061b0a Allow preventing BlockDestroyEvent from dropping items (#8349) 2022-09-08 16:13:50 +01:00
Spottedleaf
a2df674cc0 Re-add legacy getChunkAtAsynchronously to ChunkProviderServer
Apparently some plugins use it
2022-09-02 04:41:08 -07:00
Spottedleaf
0ee53db50a Fix World#refreshChunk not working for chunks in no-tick range
The chunk would not be marked as ticking in this case, so
retrieving the ticking chunk would not work.
2022-09-01 15:39:24 -07:00
Spottedleaf
90da9124c5 Re-arrange most chunk system patches to front (#8338)
* Re-arrange most chunk system patches to front

Co-authored-by: Spottedleaf <Spottedleaf@users.noreply.github.com>
2022-09-01 09:51:59 -07:00
Spottedleaf
61a8488806 Ensure players are removed from pendingLogin
Looks like they would not have been removed if they disconnected
during the chunk load, preventing the world from being unloaded.
2022-08-29 06:21:45 -07:00
Spottedleaf
9760e8f86a Prevent unloading worlds with pending player logins
Logging into an unloaded world isn't going to end well.
This may fix the cases of people seeing errors about regionfiles
being closed, as loading chunks in an unloaded world will cause this
as the regionfile cache is closed but not cleared.
2022-08-26 21:56:55 -07:00
Nassim Jahnke
b81ec3b8b5 Fix client lag spikes due to client light recalc 2022-08-25 12:59:08 +02:00
José Miguel Moreno
df753f9b3f Fix plugin loggers on shutdown (#5592)
Potentially this should be merged back into the original logging changes patches
2022-08-21 04:57:17 +02:00
Nassim Jahnke
0446f518f4 Updated Upstream (Bukkit/CraftBukkit)
Upstream has released updates that appear to apply and compile correctly.
This update has not been tested by PaperMC and as with ANY update, please do your own testing

Bukkit Changes:
0b32cbaa PR-782: ThrownPotion now extends ThrowableProjectile
474238ca SPIGOT-7138: Can't retrieve pixel color from map

CraftBukkit Changes:
cdef8fc72 PR-1097: CraftThrownPotion now extends CraftThrowableProjectile
419010b13 SPIGOT-7112: Mobs added 1.17 and after do not create an EntityTargetEvent properly
e71426201 SPIGOT-7079: Allays don't call EntityTargetEvent on ground items
f80adb8b9 SPIGOT-7138: Can't retrieve pixel color from map
2022-08-17 13:02:35 +02:00
petersv5
53102645d2 Grant temporary immunity to hopper minecarts while actively pulling (fixes #8281) (#8282)
Reduce the impact from EAR on hopper minecart based unloaders by making them immune to
EAR while pulling objects. The EAR is still active outside misc activation range when
the hopper minecart is idle, keeping lag low.
2022-08-14 19:41:15 +02:00
Nassim Jahnke
1e9ec27588 More ThrownPotion API 2022-08-14 16:53:36 +02:00
Josh Roy
89ee9379b2 Add NamespacedKey biome methods
Co-authored-by: Thonk <30448663+ExcessiveAmountsOfZombies@users.noreply.github.com>
2022-08-14 12:23:57 -04:00
Pedro
a16e146a5b [ci skip] Show @org.bukkit.UndefinedNullability in javadocs (#8291) 2022-08-14 12:18:39 -04:00
Nassim Jahnke
e8d9f65042 Add method to get highest anger level of warden 2022-08-14 10:25:28 +02:00